Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add version info in nav and Status screen, tighten nav accordingly #1654

Merged
merged 4 commits into from
Oct 5, 2020

Conversation

jessicaschilling
Copy link
Contributor

@jessicaschilling jessicaschilling commented Sep 28, 2020

Closes #1650.
Closes #1649.

This PR ...

  • Adds WebUI version number (linked to appropriate release page on GitHub) on both the nav (at widths wide enough for nav to appear at page left) and the Status screen
  • Tightens left-nav formatting to improve display for smaller 16x9 format screens (as identified in The webUI should display the webui version #1649 (comment)), primarily to preserve display of version/revision/repo/bug-report links at nav bottom for 640+ high windows

Big thanks to @bertrandfalguiere for raising these issues and PRing an initial fix!

Screenshot
Mac Chrome, 660px high, new version on the right:
image

@jessicaschilling
Copy link
Contributor Author

@bertrandfalguiere, do you mind testing this on your setup to see if this takes care of your height issue? This should also enable you to see #1651 in action. Thanks!

@bertrandfalguiere
Copy link
Contributor

bertrandfalguiere commented Sep 30, 2020

It works for me! You can merge it :)

image

@jessicaschilling
Copy link
Contributor Author

jessicaschilling commented Sep 30, 2020

@lidel and @rafaelramalho19 -- do you mind a quick look when you get the chance?
Hang on - actually going to include changes from #1651 here for ease of review.

@jessicaschilling jessicaschilling changed the title fix: tighten left nav for wide but shallow screens feat: add version info in nav and Status screen, tighten nav accordingly Sep 30, 2020
@jessicaschilling jessicaschilling added this to the v2.12 milestone Sep 30, 2020
@jessicaschilling
Copy link
Contributor Author

OK ... @lidel and @rafaelramalho19, ready for review at your leisure. Thank you!

lidel
lidel previously requested changes Oct 1, 2020
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Having this on status is 👌, but see nit below

public/locales/en/app.json Outdated Show resolved Hide resolved
@jessicaschilling
Copy link
Contributor Author

@lidel - Updated to just "UI". Screenshot updated in original comment at the top of this issue, but here too to avoid repetitive stress injury from scrolling:
image

@jessicaschilling jessicaschilling requested a review from lidel October 1, 2020 23:09
Copy link
Contributor

@rafaelramalho19 rafaelramalho19 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚢

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Tighten height of left nav The webUI should display the webui version
4 participants