-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add version info in nav and Status screen, tighten nav accordingly #1654
Conversation
@bertrandfalguiere, do you mind testing this on your setup to see if this takes care of your height issue? This should also enable you to see #1651 in action. Thanks! |
|
OK ... @lidel and @rafaelramalho19, ready for review at your leisure. Thank you! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Having this on status is 👌, but see nit below
@lidel - Updated to just "UI". Screenshot updated in original comment at the top of this issue, but here too to avoid repetitive stress injury from scrolling: |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM 🚢
Closes #1650.
Closes #1649.
This PR ...
Big thanks to @bertrandfalguiere for raising these issues and PRing an initial fix!
Screenshot
Mac Chrome, 660px high, new version on the right: