Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: remote pin error feedback #1760

Merged
merged 2 commits into from
Apr 12, 2021
Merged

feat: remote pin error feedback #1760

merged 2 commits into from
Apr 12, 2021

Conversation

rafaelramalho19
Copy link
Contributor

Closes #1751

@rafaelramalho19 rafaelramalho19 self-assigned this Apr 8, 2021
lidel
lidel approved these changes Apr 8, 2021
View reviewed changes
Copy link
Member

@lidel lidel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but let's wait for @jessicaschilling to 👀 the text.

public/locales/en/notify.json Outdated Show resolved Hide resolved
@jessicaschilling
Copy link
Contributor

LGTM with @lidel's suggestion!

@rafaelramalho19 @lidel
Update public/locales/en/notify.json
46febe8 
Co-authored-by: Marcin Rataj <lidel@lidel.org>
@lidel lidel merged commit e88f163 into master Apr 12, 2021
@lidel lidel deleted the feat/remote-pin-error-feedback branch April 12, 2021 01:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jessicaschilling jessicaschilling jessicaschilling left review comments

@lidel lidel lidel approved these changes

Assignees

@rafaelramalho19 rafaelramalho19

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Files: remote pin error feedback
3 participants
@rafaelramalho19 @jessicaschilling @lidel