Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: add Web3.Storage and Estuary to default pinning provider list #2026

Merged
merged 3 commits into from
Sep 15, 2022
Merged

feat: add Web3.Storage and Estuary to default pinning provider list #2026

merged 3 commits into from
Sep 15, 2022

Conversation

SgtPooki
Copy link
Member

@SgtPooki SgtPooki commented Sep 14, 2022 •
edited
Loading

  • feat: add Web3.Storage default pinning provider
  • feat: add Estuary default pinning provider

image

@SgtPooki SgtPooki requested a review from a team as a code owner September 14, 2022 18:30
@SgtPooki SgtPooki mentioned this pull request Sep 14, 2022
Closed
@SgtPooki SgtPooki temporarily deployed to Deploy September 14, 2022 18:35 Inactive
@SgtPooki SgtPooki linked an issue Sep 14, 2022 that may be closed by this pull request
Add pinning service providers to default list #2004
Closed
5 tasks
@SgtPooki SgtPooki changed the title 2004 add pinning service providers to default list estuary feat: add Web3.Storage and Estuary to default pinning provider list Sep 14, 2022
@SgtPooki
Copy link
Member Author

Links to compliance reports are all working as well
image

lidel
lidel requested changes Sep 14, 2022
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, but when this will ship with IPFS Desktop and Kubo,
it may introduce these services to less technically sophisticated users.

Before we merge this, would like to get official 👍 from projects themselves.

Pinging:

src/constants/pinning.js Outdated Show resolved Hide resolved
@lidel lidel added the status/blocked Unable to be worked further until needs are met label Sep 14, 2022
@jimmylee
Copy link

LGTM

vasco-santos
vasco-santos approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍🏼

lidel
lidel approved these changes Sep 15, 2022
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We got 👍 from both teams :)

@lidel lidel temporarily deployed to Deploy September 15, 2022 17:48 Inactive
@lidel lidel removed the status/blocked Unable to be worked further until needs are met label Sep 15, 2022
@lidel lidel merged commit 3aae1f2 into main Sep 15, 2022
@lidel lidel deleted the 2004-add-pinning-service-providers-to-default-list-estuary branch September 15, 2022 19:35
@lidel lidel mentioned this pull request Sep 15, 2022
Merged
ipfs-gui-bot pushed a commit that referenced this pull request Oct 3, 2022
@semantic-release-bot
chore(release): 2.19.0 [skip ci]
b27f3be 
## [2.19.0](v2.18.1...v2.19.0) (2022-10-03)

 CID `bafybeiavrvt53fks6u32n5p2morgblcmck4bh4ymf4rrwu7ah5zsykmqqa`

 ---

### Features

* add codecov_token to codecov step ([#2044](#2044)) ([ee7cc63](ee7cc63))
* add Web3.Storage and Estuary to pinning service templates ([#2026](#2026)) ([3aae1f2](3aae1f2))

### Bug Fixes

* **settings:** randomize pinning service templates ([#2027](#2027)) ([cd211ac](cd211ac))

### Tests

* add unit&storybook coverage to codecov ([#2023](#2023)) ([1961b17](1961b17))

### Trivial Changes

* go-ipfs -> kubo name update ([#2022](#2022)) ([183c476](183c476))
* pull new translations ([#2041](#2041)) ([1be6342](1be6342))
* Pull transifex translations ([#2028](#2028)) ([5011e12](5011e12))
* replace topojson with topojson-client ([#2035](#2035)) ([e06a878](e06a878))
@ipfs-gui-bot
Copy link
Collaborator

🎉 This PR is included in version 2.19.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vasco-santos vasco-santos vasco-santos approved these changes

@lidel lidel lidel approved these changes

Assignees
No one assigned
Labels
released
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add pinning service providers to default list
5 participants
@SgtPooki @jimmylee @ipfs-gui-bot @lidel @vasco-santos