feat: ipfs-http-client -> kubo-rpc-client #2098

SgtPooki · 2023-02-10T21:35:09Z

fixes #2079

Note that this PR includes patches for kubo-rpc-client and ipld-explorer-components, both of which have PRs out:

fix: error rendering peerId fix: peers table on peerspage fix: statusPage -> advanced -> addresses fix: most e2e tests working with kubo-rpc-client chore: update to go-ipfsv0.18.1

needed until kubo-rpc-client fix is merged see ipfs/js-kubo-rpc-client#143 see ipfs/js-kubo-rpc-client#145

see https://github.com/ipfs/ipfs-webui/issues/2079\#issuecomment-1426219633 see #2079 (comment) must use until ipfs/ipld-explorer-components#356

lidel · 2023-02-13T20:35:35Z

It is awesome to see progress here, thank you, @SgtPooki ! ❤️

Quick feedback (based on Fleek preview):

UnixFS examples in IPLD Explorer seems to be broken:

Firefox:

DAG-CBOR also stopped working:

http://bafybeiamvv2dr2nhvhgyipbobewv6gmjht5rphcru3ptcjdcfogwts6zgu.ipfs.localhost:8080/#/explore/ipfs/bafyreihnpl7ami7esahkfdnemm6idx4r2n6u3apmtcrxlqwuapgjsciihy produces:

lidel

(if we were missing tests for these, we should add them as part of this PR, to avoid regressions in the future)

whizzzkid

nits and @lidel's concerns

test/e2e/setup/ipfs-backend.js

package.json

…-rpc-client

SgtPooki · 2023-02-15T21:39:07Z

@lidel have those fixed locally except for the main dag text appearing differently. working on that now

not needed once ipfs/ipld-explorer-components#356 is merged

SgtPooki · 2023-02-16T21:13:26Z

@lidel I addressed your comments, but using some of those examples are too slow for the e2e tests so I created some different CIDs that we can use to test that things are loading properly.

lidel

(mind this is late friday, so maybe i am testing wrong cid, but...)

I tested bafybeifj4cifkrs5msfcfqqrbovoxtptdgmgt3ce6nvbwitfzy6gvqekl4 from fleek preview on this PR and examples are still broken, but one level deeper :)

unable to enter into unixfs subdiretories in both examples:
- http://bafybeifj4cifkrs5msfcfqqrbovoxtptdgmgt3ce6nvbwitfzy6gvqekl4.ipfs.localhost:8080/#/explore/QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2D → click on albums
- http://bafybeifj4cifkrs5msfcfqqrbovoxtptdgmgt3ce6nvbwitfzy6gvqekl4.ipfs.localhost:8080/#/explore/QmdmQXB2mzChmMeKY47C43LxUdg1NDJ5MWcKMKxDu7RgQm/ → click on any subdir
- both produce
dag-cbor has similar problem, cant visit children nodes:
- http://bafybeifj4cifkrs5msfcfqqrbovoxtptdgmgt3ce6nvbwitfzy6gvqekl4.ipfs.localhost:8080/#/explore/bafyreihnpl7ami7esahkfdnemm6idx4r2n6u3apmtcrxlqwuapgjsciihy → click on links/0 → Error: No resolver found for codec "undefined"

SgtPooki · 2023-02-20T19:24:41Z

I'm able to reproduce locally with:

…-rpc-client

SgtPooki · 2023-02-20T19:56:04Z

got repro of the failure with XKCD in e2e test at d542fea

SgtPooki · 2023-02-22T19:35:26Z

@lidel I fixed the issue you brought up, and then found that the next level was not traversable, and fixed that.. but the test still only tests one level deep. i'm updating the test to walk as far down as possible now.

SgtPooki · 2023-02-24T01:10:55Z

@lidel @whizzzkid This is ready for review

whizzzkid

nits, lgtm

src/bundles/ipfs-provider.js

src/components/address/Address.js

test/e2e/explore.test.js

Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

…-rpc-client

lidel

Super close! 🤞 Can't wait for this to land, it will unblock #1798

Unfortunately, we have regressions before reaching deeper leaf nodes (deeper than one level) 😿

dag-pb
- 🟠 http://localhost:3000/#/explore/QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2D/albums/QXBvbGxvIDE0IE1hZ2F6aW5lIDY0L0xM/21076541854_939b42d8d8_o.jpg opens ok, but clicking on any of its children, like Links/0 will error:
  - 🔴 http://localhost:3000/#/explore/QmSnuWmxptJZdLJpKRarxBMS2Ju2oANVrgbr2xWbie9b2D/albums/QXBvbGxvIDE0IE1hZ2F6aW5lIDY0L0xM/21076541854_939b42d8d8_o.jpg/Links/0
same for dag-cbor:
- old version opened ℹ️ http://127.0.0.1:5001/ipfs/bafybeiequgo72mrvuml56j4gk7crewig5bavumrrzhkqbim6b3s2yqi7ty/#/explore/bafyreihnpl7ami7esahkfdnemm6idx4r2n6u3apmtcrxlqwuapgjsciihy/links/0/links/0/links/0/links/0 just fine,
  but this PR fails 2 levels of links deep: 🔴 http://localhost:3000/#/explore/bafyreihnpl7ami7esahkfdnemm6idx4r2n6u3apmtcrxlqwuapgjsciihy/links/0/links/0 → fails

lidel · 2023-03-02T23:20:16Z

patches/ipld-explorer-components+3.0.3.patch

@@ -0,0 +1,355 @@
+diff --git a/node_modules/ipld-explorer-components/dist/bundles/explore.js b/node_modules/ipld-explorer-components/dist/bundles/explore.js


💭 I assume this patching will go away after ipfs/ipld-explorer-components#356 is bubbled up, so I did not review this.

test/e2e/explore.test.js

SgtPooki · 2023-03-13T18:06:38Z

Since i've confirmed issues with apollo archive are fixed locally, and tests are diving fully into the XKCD archives, i'm going to merge this, though I created a follow up issue for addressing test concerns: #2106

## [3.0.0](v2.22.0...v3.0.0) (2023-04-24) CID `bafybeic4gops3d3lyrisqku37uio33nvt6fqxvkxihrwlqsuvf76yln4fm` --- ### ⚠ BREAKING CHANGES * migrate to ESM (#2092) ### Features * ipfs-http-client -> kubo-rpc-client ([#2098](#2098)) ([5e53c79](5e53c79)), closes [#issuecomment-1426219633](https://github.com/ipfs/ipfs-webui/issues/issuecomment-1426219633) [/github.com//issues/2079#issuecomment-1426337490](https://github.com/ipfs//github.com/ipfs/ipfs-webui/issues/2079/issues/issuecomment-1426337490) * migrate to ESM ([#2092](#2092)) ([58a737c](58a737c)) ### Bug Fixes * e2e/explore.test.js succeeds in offline mode ([#2109](#2109)) ([a5e9ac6](a5e9ac6)) * ko language falls back to ko-KR ([#2102](#2102)) ([3369800](3369800)) * semantic release custom notes import ([#2113](#2113)) ([2f9f306](2f9f306)) ### Trivial Changes * add NetworkTraffic.stories.js ([#2094](#2094)) ([7a3bf46](7a3bf46)) * pull new translations ([#2101](#2101)) ([cbabac3](cbabac3)) * pull new translations ([#2104](#2104)) ([4a691a2](4a691a2)) * Pull transifex translations ([#2088](#2088)) ([a5b8a1c](a5b8a1c)) * Pull transifex translations ([#2091](#2091)) ([d209863](d209863)) * Pull transifex translations ([#2099](#2099)) ([1cf2fe7](1cf2fe7)) * Pull transifex translations ([#2111](#2111)) ([57d9b63](57d9b63))

ipfs-gui-bot · 2023-04-24T20:07:07Z

🎉 This PR is included in version 3.0.0 🎉

The release is available on GitHub release

Your semantic-release bot 📦🚀

SgtPooki added 3 commits February 10, 2023 13:31

feat!: ipfs-http-client -> kubo-rpc-client

608209e

fix: error rendering peerId fix: peers table on peerspage fix: statusPage -> advanced -> addresses fix: most e2e tests working with kubo-rpc-client chore: update to go-ipfsv0.18.1

chore: fix key.gen with patch

335fd28

needed until kubo-rpc-client fix is merged see ipfs/js-kubo-rpc-client#143 see ipfs/js-kubo-rpc-client#145

fix: use ipld-explorer-components patch temporarily

fd92e48

see https://github.com/ipfs/ipfs-webui/issues/2079\#issuecomment-1426219633 see #2079 (comment) must use until ipfs/ipld-explorer-components#356

SgtPooki requested a review from a team as a code owner February 10, 2023 21:35

SgtPooki linked an issue Feb 10, 2023 that may be closed by this pull request

feat!: replace ipfs-http-client with kubo-rpc-client #2079

Closed

SgtPooki temporarily deployed to Deploy February 10, 2023 21:40 — with GitHub Actions Inactive

SgtPooki requested review from whizzzkid and lidel February 10, 2023 21:41

SgtPooki self-assigned this Feb 10, 2023

lidel requested changes Feb 13, 2023

View reviewed changes

whizzzkid reviewed Feb 14, 2023

View reviewed changes

test/e2e/setup/ipfs-backend.js Show resolved Hide resolved

package.json Show resolved Hide resolved

Merge branch 'main' into 2079-feat-replace-ipfs-http-client-with-kubo…

0e5ce08

…-rpc-client

SgtPooki temporarily deployed to Deploy February 14, 2023 18:43 — with GitHub Actions Inactive

SgtPooki added 3 commits February 15, 2023 14:25

chore: fix ipld-explorer-components patch

8827179

not needed once ipfs/ipld-explorer-components#356 is merged

test: add tests to explore.test.js

b975524

tmp: trying to navigate the undocumented world of parsing CIDs

81f828d

SgtPooki temporarily deployed to Deploy February 16, 2023 02:27 — with GitHub Actions Inactive

SgtPooki added 4 commits February 16, 2023 12:02

chore: working on getting tests fully tied up

05074e3

test(e2e): finish updating explore.test.js

8de6768

chore: lint fixes

63ab57c

chore: remove debugging code

a0cee82

SgtPooki temporarily deployed to Deploy February 16, 2023 21:06 — with GitHub Actions Inactive

SgtPooki requested review from whizzzkid and lidel February 16, 2023 21:07

SgtPooki mentioned this pull request Feb 17, 2023

IPFS Ignite Roadmap - 2022->2023 ipfs/ipfs-gui#106

Open

lidel requested changes Feb 18, 2023

View reviewed changes

Merge branch 'main' into 2079-feat-replace-ipfs-http-client-with-kubo…

8326432

…-rpc-client

SgtPooki temporarily deployed to Deploy February 20, 2023 19:36 — with GitHub Actions Inactive

test: test clicking children links on explore page

d542fea

SgtPooki temporarily deployed to Deploy February 20, 2023 20:00 — with GitHub Actions Inactive

tmp: fix children explore views

2cde625

SgtPooki temporarily deployed to Deploy February 22, 2023 19:10 — with GitHub Actions Inactive

SgtPooki requested a review from lidel February 22, 2023 19:34

test: e2e explore test traverses children

d5f698a

SgtPooki temporarily deployed to Deploy February 22, 2023 20:00 — with GitHub Actions Inactive

whizzzkid approved these changes Feb 24, 2023

View reviewed changes

src/bundles/ipfs-provider.js Outdated Show resolved Hide resolved

src/components/address/Address.js Show resolved Hide resolved

test/e2e/explore.test.js Outdated Show resolved Hide resolved

test/e2e/explore.test.js Show resolved Hide resolved

SgtPooki and others added 2 commits February 24, 2023 16:41

Update test/e2e/explore.test.js

d5177c1

Co-authored-by: Nishant Arora <1895906+whizzzkid@users.noreply.github.com>

Merge branch 'main' into 2079-feat-replace-ipfs-http-client-with-kubo…

17e2f08

…-rpc-client

SgtPooki temporarily deployed to Deploy February 25, 2023 00:46 — with GitHub Actions Inactive

chore: address PR comments

739d55d

SgtPooki temporarily deployed to Deploy February 25, 2023 02:09 — with GitHub Actions Inactive

Merge branch 'main' into 2079-feat-replace-ipfs-http-client-with-kubo…

31b4d99

…-rpc-client

SgtPooki temporarily deployed to Deploy February 27, 2023 17:28 — with GitHub Actions Inactive

lidel requested changes Mar 3, 2023

View reviewed changes

SgtPooki mentioned this pull request Mar 13, 2023

test: improve explore page tests #2106

Closed

SgtPooki merged commit 5e53c79 into main Mar 13, 2023

SgtPooki deleted the 2079-feat-replace-ipfs-http-client-with-kubo-rpc-client branch March 13, 2023 18:06

SgtPooki mentioned this pull request Mar 20, 2023

bug: new e2e tests for explore page are failing in kubo CI #2108

Closed

ipfs-gui-bot added the released label Apr 24, 2023

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

feat: ipfs-http-client -> kubo-rpc-client #2098

feat: ipfs-http-client -> kubo-rpc-client #2098

SgtPooki commented Feb 10, 2023 •

edited

Loading

lidel commented Feb 13, 2023 •

edited

Loading

lidel left a comment

whizzzkid left a comment

SgtPooki commented Feb 15, 2023

SgtPooki commented Feb 16, 2023

lidel left a comment

SgtPooki commented Feb 20, 2023

SgtPooki commented Feb 20, 2023

SgtPooki commented Feb 22, 2023

SgtPooki commented Feb 24, 2023

whizzzkid left a comment

lidel left a comment •

edited

Loading

lidel Mar 2, 2023 •

edited

Loading

SgtPooki commented Mar 13, 2023

ipfs-gui-bot commented Apr 24, 2023

		@@ -0,0 +1,355 @@
		diff --git a/node_modules/ipld-explorer-components/dist/bundles/explore.js b/node_modules/ipld-explorer-components/dist/bundles/explore.js

feat: ipfs-http-client -> kubo-rpc-client #2098

feat: ipfs-http-client -> kubo-rpc-client #2098

Conversation

SgtPooki commented Feb 10, 2023 • edited Loading

lidel commented Feb 13, 2023 • edited Loading

lidel left a comment

Choose a reason for hiding this comment

whizzzkid left a comment

Choose a reason for hiding this comment

SgtPooki commented Feb 15, 2023

SgtPooki commented Feb 16, 2023

lidel left a comment

Choose a reason for hiding this comment

SgtPooki commented Feb 20, 2023

SgtPooki commented Feb 20, 2023

SgtPooki commented Feb 22, 2023

SgtPooki commented Feb 24, 2023

whizzzkid left a comment

Choose a reason for hiding this comment

lidel left a comment • edited Loading

Choose a reason for hiding this comment

lidel Mar 2, 2023 • edited Loading

Choose a reason for hiding this comment

SgtPooki commented Mar 13, 2023

ipfs-gui-bot commented Apr 24, 2023

SgtPooki commented Feb 10, 2023 •

edited

Loading

lidel commented Feb 13, 2023 •

edited

Loading

lidel left a comment •

edited

Loading

lidel Mar 2, 2023 •

edited

Loading