Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: ko language falls back to ko-KR #2102

Merged
merged 15 commits into from
Feb 25, 2023
Merged

fix: ko language falls back to ko-KR #2102

merged 15 commits into from
Feb 25, 2023

Commits on Feb 23, 2023

  1. test: test i18n languages and fallbacks

    @SgtPooki
    SgtPooki committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    e97c5c9 View commit details
    Browse the repository at this point in the history

  2. test(i18n): use available port

    @SgtPooki
    SgtPooki committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    87b68e6 View commit details
    Browse the repository at this point in the history

  3. chore: add all local files for ko-KR 

    english has 8 locale files:
`ls -lhatr public/locales/en/*.json  | wc -l # 8`

before this change, ko-KR only had 4
`ls -lhatr public/locales/ko-KR/*.json  | wc -l # 4`

so I copied them over using
`cp -n public/locales/en/*.json public/locales/ko-KR/`

after this change
`ls -lhatr public/locales/ko-KR/*.json  | wc -l # 8`
    @SgtPooki
    SgtPooki committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    d1cac49 View commit details
    Browse the repository at this point in the history

  4. chore(i18n): ensure app:actions.add has ko translation

    @SgtPooki
    SgtPooki committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    db17cd8 View commit details
    Browse the repository at this point in the history

  5. fix: only send i18n requests for current language 

    Sends only a single request for lang via i18n-http-backend

see i18next/i18next-http-backend#61
    @SgtPooki
    SgtPooki committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    fc24e90 View commit details
    Browse the repository at this point in the history

  6. fix: current language displays correctly for fallbacks

    @SgtPooki
    SgtPooki committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    b3db8ac View commit details
    Browse the repository at this point in the history

  7. test(lib/i18n): test getLanguage function

    @SgtPooki
    SgtPooki committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    cea0eee View commit details
    Browse the repository at this point in the history

  8. test(lib/i18n): add getCurrentLanguage test

    @SgtPooki
    SgtPooki committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    ad2cb3e View commit details
    Browse the repository at this point in the history

  9. test(i18n): add test for naming languages in languages.json

    @SgtPooki
    SgtPooki committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    cc3c9e9 View commit details
    Browse the repository at this point in the history

  10. fix(i18n): add parser for getting valid locale codes

    @SgtPooki
    SgtPooki committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    b7657da View commit details
    Browse the repository at this point in the history

  11. fix(lib/i18n): use i18n-localeParser

    @SgtPooki
    SgtPooki committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    54749f4 View commit details
    Browse the repository at this point in the history

  12. fix(i18n): prevent the lookup of invalid locales 

    fixes #2097
    @SgtPooki
    SgtPooki committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    7eb9327 View commit details
    Browse the repository at this point in the history

  13. test(e2e:settings): test language selector

    @SgtPooki
    SgtPooki committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    fb59953 View commit details
    Browse the repository at this point in the history

  14. test(e2e/settings): validate that language files are requested

    @SgtPooki
    SgtPooki committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    c81c2a2 View commit details
    Browse the repository at this point in the history

  15. chore: remove untranslated ko-KR files

    @SgtPooki
    SgtPooki committed Feb 23, 2023
    Configuration menu
    Copy the full SHA
    594e0ba View commit details
    Browse the repository at this point in the history