fix(files): avoid duplicated fetch during preview #2254
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SgtPooki
approved these changes
Sep 3, 2024
| @@ -214,7 +214,7 @@ const actions = () => ({ | |||
| ...fileFromStats({ ...stats, path }), | |||
| fetched: time, | |||
| type: 'file', | |||
| read: () => ipfs.cat(stats.cid), | |||
| read: (offset, length) => ipfs.cat(stats.cid, { offset, length }), | |||
There was a problem hiding this comment.
nit: this CI action is failing but this is not a TS file.. we could add jsdoc..
do we want to disable typecheck CI while we are not full typescript?
There was a problem hiding this comment.
Let's keep it, we get contributions from people, and better if they include types (easier for us to review).
I've added jsdoc.
Co-authored-by: Russell Dempsey <1173416+SgtPooki@users.noreply.github.com>
ipfs-gui-bot
pushed a commit
that referenced
this pull request
Sep 23, 2024
## [4.3.1](v4.3.0...v4.3.1) (2024-09-23) CID `bafybeideglc722hiwhsy4kiyl2fivf5lr6wozy2iuixtgzkvl3v4hasaty` --- ### Bug Fixes * **file-preview:** safeSubresourceGwUrl ([#2253](#2253)) ([bb861a3](bb861a3)), closes [/github.com//issues/2246#issuecomment-2322192398](https://github.com/ipfs//github.com/ipfs/ipfs-webui/issues/2246/issues/issuecomment-2322192398) * **files:** avoid duplicated fetch during preview ([#2254](#2254)) ([eefae25](eefae25)), closes [#2217](#2217) * **files:** prefer subdomain gw in copied share links ([#2255](#2255)) ([e8c4421](e8c4421)) ### Trivial Changes * .io → .tech ([b9f622d](b9f622d)) * browserslist@latest ([#2251](#2251)) ([809c55a](809c55a)) * Pull transifex translations ([#2258](#2258)) ([2250374](2250374)) * use ipld-explorer-components@7.0.2 ([#2257](#2257)) ([99ba9ac](99ba9ac))
|
🎉 This PR is included in version 4.3.1 🎉 The release is available on GitHub release Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ipfs.catif file is embedded as subresource (image, video, pdf, audio)ipfs.catto 10KiB for other files typesPreview
Can be tested with big txt file, like
bafybeicbevt3gr2jhs23f2sikwcqtirrhrdyscriutfg5mtlxoud55htii