world spec #253
Closed
world spec #253
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yeah |
| it('should render an svg', () => { | ||
| const c = [[12, 14]] | ||
|
|
||
| const el = render(<WorldMap coordinates={c}/>) |
There was a problem hiding this comment.
I decided to do a static render here since this component only has one child.
| const c = [[12, 14]] | ||
|
|
||
| const el = render(<WorldMap coordinates={c}/>) | ||
| expect(el.find('svg').length).to.equal(1) |
There was a problem hiding this comment.
I tried to think of more meaningful assertions to add here but drew a blank. The resulting output of _renderMap is basically all generated by d3 and I couldn't find anything else on the rendered output that could be used to assert correctness.
There was a problem hiding this comment.
You could assert that the point is drawn that you passed in
|
💯 |
| expect(el.find('svg').length).to.equal(1) | ||
| }) | ||
|
|
||
| it('should have the correct coordiates', () => { |
|
Thanks, one small note other than it looks good. Could you squash your commits together please? |
Merged
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
#137
I'm not sure if
_renderMapis testable here without either exposing it or doing a non-shallow render(not advisable for unit tests).We could also make this a separate react component with width/height as state, if it's reusable.