-
Notifications
You must be signed in to change notification settings - Fork 492
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Show files in recursively pinned directories, wrap additions #39
Conversation
And yes, this also automatically recursive-pins any file added this way |
yay for progress! what about files that are pinned directly? And files not pinned? Idea originally was to have a "cached" tab too that showed all the objects stored locally. One way to get around the lack of names In some objects is to have a checkbox that filters out the ones lacking dir names? (What's worse, not showing objects that are taking up space, or not showing clean names?) |
(May be good to post screenshots of webui changes, so people can follow along without having to download compile and run. (Which is impossible in iOS :( )) |
@krl still unsure whether this PR is the right way fwd atm -- a couple screenshots + discuss re comments above? o/ (also relevant to mention what we were discussing today-- namely still showing tabs, with:
And then "cached" and "pinned" could be filters on the page. I.e. toggle between "all | pinned | cached". @krl am i being clear saying "roots"? basically mean objects which are not pointed at by any other object. |
I think that the files tab should be replaced with the local file browser i propose in #41 |
👍 |
deprecated waiting for proper pinning system |
This might be a bit controversial, i removed the different tabs partly because the rearrangement of the way the files are queried for.
At this point, the interface asks for all recursively pinned objects, and pipes them through ipfs.ls, to get the files that actually have displayable names, and lists just those.
This also depends on my small fix to the api, we should probably also do a new release first and fix the version in package.json