Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show files in recursively pinned directories, wrap additions #39

Closed
wants to merge 1 commit into from

Conversation

krl
Copy link
Contributor

@krl krl commented Apr 29, 2015

This might be a bit controversial, i removed the different tabs partly because the rearrangement of the way the files are queried for.

At this point, the interface asks for all recursively pinned objects, and pipes them through ipfs.ls, to get the files that actually have displayable names, and lists just those.

This also depends on my small fix to the api, we should probably also do a new release first and fix the version in package.json

@jbenet jbenet added the status/in-progress In progress label Apr 29, 2015
@krl
Copy link
Contributor Author

krl commented Apr 29, 2015

And yes, this also automatically recursive-pins any file added this way

@jbenet
Copy link
Member

jbenet commented May 1, 2015

yay for progress!

what about files that are pinned directly? And files not pinned? Idea originally was to have a "cached" tab too that showed all the objects stored locally.

One way to get around the lack of names In some objects is to have a checkbox that filters out the ones lacking dir names? (What's worse, not showing objects that are taking up space, or not showing clean names?)

@jbenet
Copy link
Member

jbenet commented May 1, 2015

(May be good to post screenshots of webui changes, so people can follow along without having to download compile and run. (Which is impossible in iOS :( ))

@jbenet
Copy link
Member

jbenet commented May 5, 2015

@krl still unsure whether this PR is the right way fwd atm -- a couple screenshots + discuss re comments above? o/ (also relevant to mention what we were discussing today-- namely still showing tabs, with:

  • files -- all the roots that are named -- so not proper roots, but the first children of roots i guess. (files inside directories can be accessed via the directory) (this covers the average user's use case: wanting to see files as they added them, with names).
  • objects -- lists all the object roots (hashes, not names) -- this covers the power user case of wanting to see what's here.

And then "cached" and "pinned" could be filters on the page. I.e. toggle between "all | pinned | cached".
i can sketch this out if needed for clarity.

@krl am i being clear saying "roots"? basically mean objects which are not pointed at by any other object.

@whyrusleeping
Copy link
Member

I think that the files tab should be replaced with the local file browser i propose in #41

@jbenet
Copy link
Member

jbenet commented May 5, 2015

👍

@whyrusleeping whyrusleeping mentioned this pull request May 11, 2015
30 tasks
@krl
Copy link
Contributor Author

krl commented May 16, 2015

deprecated waiting for proper pinning system

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants