feat: navbar width toggle #710
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Click on the logo to collapse the side nav. Click again to get it back. License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
License: MIT Signed-off-by: Oli Evans <oli@tableflip.io>
fsdiogo
approved these changes
Jul 6, 2018
|
@fsdiogo strongly agree. I'll add something that appears when you hover over the nav. |
|
(in another PR tho) |
|
Awesome 👌 We can think of something cool 😎 |
hacdias
approved these changes
Jul 6, 2018
hacdias
reviewed
Jul 6, 2018
There was a problem hiding this comment.
Just found an issue:
This happens because we need to tell the size of the action bar. Could you just take a look at this, please?
If you're busy I can see if I can take care of it.
|
I'm merging this. I have a way to fix the size of the action bar |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Click on the logo to collapse the side nav. Click again to get it back. Invision design here: https://projects.invisionapp.com/d/main#/console/13924274/294213563/preview
(the weirdness with the light blue top bar is just an artefact from the gif screen recorder.)
License: MIT
Signed-off-by: Oli Evans oli@tableflip.io