Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: drag'n'drop files #729

Merged
merged 21 commits into from
Jul 20, 2018
Merged

feat: drag'n'drop files #729

merged 21 commits into from
Jul 20, 2018

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Jul 18, 2018 •
edited
Loading

  • Drop Files and Folders
  • Move files and folders by drag and dropping them
  • Move multiple files ^^

License: MIT
Signed-off-by: Henrique Dias hacdias@gmail.com

@hacdias hacdias changed the title feat: drag'n'drop files [wip] feat: drag'n'drop files Jul 18, 2018
@hacdias hacdias self-assigned this Jul 18, 2018
@hacdias hacdias mentioned this pull request Jul 18, 2018
Closed
18 tasks
@hacdias hacdias changed the title [wip] feat: drag'n'drop files feat: drag'n'drop files Jul 19, 2018
@hacdias hacdias requested review from olizilla, lidel, alanshaw and fsdiogo and removed request for olizilla, lidel and alanshaw July 19, 2018 10:26
@hacdias
Copy link
Member Author

hacdias commented Jul 19, 2018

@olizilla @lidel @alanshaw @fsdiogo try dropping files, folders and a mix of files and folders to make sure everything works well. Also, you can drag files and folders already on the UI and move them to other folders.

@hacdias
fix for multiple files
89eff24
@hacdias
fix linting
2abd52f
@hacdias
better checkbox
f3adf14
@hacdias
fix uploads via Add btn
0ffac22
@hacdias
Avoid calling when it's loading
3bf2987 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
Move downloadFile to bundle and some cleaning
a895006 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
remove downloadFile from bundle
c9b6f6e 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@hacdias
update pkg lock
82dedb9 
License: MIT
Signed-off-by: Henrique Dias <hacdias@gmail.com>
@fsdiogo
Copy link
Contributor

fsdiogo commented Jul 19, 2018

@hacdias everything seems to be working fine 👌

I just think we should hint that it's possible to drag and drop files to upload them, but not sure how 🤔

fsdiogo
fsdiogo approved these changes Jul 19, 2018
View reviewed changes
Copy link
Contributor

@fsdiogo fsdiogo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍

@hacdias
Copy link
Member Author

hacdias commented Jul 20, 2018

I'm merging this to master. If there is anything that can be improved, we can do it on another PR 😄

@hacdias hacdias merged commit dc99b56 into revamp Jul 20, 2018
@hacdias hacdias deleted the feat/revamp/dnd branch July 20, 2018 12:56
@snyk-bot snyk-bot mentioned this pull request Jun 1, 2021
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@fsdiogo fsdiogo fsdiogo approved these changes

@olizilla olizilla Awaiting requested review from olizilla

@lidel lidel Awaiting requested review from lidel

@alanshaw alanshaw Awaiting requested review from alanshaw

Assignees

@hacdias hacdias

Labels
status/in-progress In progress
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@hacdias @fsdiogo