Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: minimum translation percentage #914

Merged
merged 2 commits into from
Dec 18, 2018
Merged

fix: minimum translation percentage #914

merged 2 commits into from
Dec 18, 2018

Conversation

fsdiogo
Copy link
Contributor

@fsdiogo fsdiogo commented Dec 18, 2018

The minimum percentage for pulling translations was 1%; that pulled files with almost no strings translated.

Updated the minimum percentage to 75%.

@ghost ghost assigned fsdiogo Dec 18, 2018
@ghost ghost added the status/in-progress In progress label Dec 18, 2018
@olizilla
Copy link
Member

We need to clear our all the locales other than en from the public/locales dir, and then pull from transifex to see which translations dont meet the new threshhold. Then check which of the localData imports we still need, and recreate the languages.json which you can re-generate via lol

@fsdiogo
Copy link
Contributor Author

fsdiogo commented Dec 18, 2018

Done @olizilla!

olizilla
olizilla approved these changes Dec 18, 2018
View reviewed changes
Copy link
Member

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@fsdiogo fsdiogo merged commit 5ed934b into master Dec 18, 2018
@ghost ghost removed the status/in-progress In progress label Dec 18, 2018
@fsdiogo fsdiogo deleted the fix/minimum-translation-percentage branch December 18, 2018 17:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@olizilla olizilla olizilla approved these changes

@lidel lidel Awaiting requested review from lidel

Assignees

@fsdiogo fsdiogo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fsdiogo @olizilla