fix: add folder #924
Merged
fix: add folder #924
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
fsdiogo
commented
Jan 4, 2019
| @@ -241,17 +241,22 @@ export default (opts = {}) => { | |||
| progress: updateProgress | |||
| }) | |||
|
|
|||
| if (res.length !== streams.length + 1) { | |||
| if (res.length !== streams.length + 2) { | |||
There was a problem hiding this comment.
Not sure when this changed, but it was always failing because of this!
There was a problem hiding this comment.
interesting, it's returning an entry for the folder, and the parent of the folder. This fixes our logic around it, so +1
olizilla
approved these changes
Jan 4, 2019
| @@ -241,17 +241,22 @@ export default (opts = {}) => { | |||
| progress: updateProgress | |||
| }) | |||
|
|
|||
| if (res.length !== streams.length + 1) { | |||
| if (res.length !== streams.length + 2) { | |||
There was a problem hiding this comment.
interesting, it's returning an entry for the folder, and the parent of the folder. This fixes our logic around it, so +1
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Adding a folder was failing because of the length of the api response. It would also fail and give an incoherent error if adding a folder with an existing folder name.
Fixes #922.