Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: use localeCompare to sort files #977

Merged
merged 5 commits into from
Feb 28, 2019
Merged

fix: use localeCompare to sort files #977

merged 5 commits into from
Feb 28, 2019

Conversation

fsdiogo
Copy link
Contributor

@fsdiogo fsdiogo commented Feb 25, 2019

Fixes #975.

@fsdiogo fsdiogo self-assigned this Feb 25, 2019
@ghost ghost added the status/in-progress In progress label Feb 25, 2019
olizilla
olizilla requested changes Feb 26, 2019
View reviewed changes
src/bundles/files.js Outdated Show resolved Hide resolved
@olizilla olizilla mentioned this pull request Feb 26, 2019
Closed
10 tasks
olizilla
olizilla reviewed Feb 26, 2019
View reviewed changes
src/bundles/files.js Outdated Show resolved Hide resolved
olizilla
olizilla approved these changes Feb 28, 2019
View reviewed changes
Copy link
Member

@olizilla olizilla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🌟 ✨ 💖

@olizilla olizilla merged commit 45a2650 into master Feb 28, 2019
@olizilla olizilla deleted the fix/use-localecompare-to-sort-files branch February 28, 2019 13:18
@ghost ghost removed the status/in-progress In progress label Feb 28, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hacdias hacdias hacdias left review comments

@olizilla olizilla olizilla approved these changes

Assignees

@fsdiogo fsdiogo

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@fsdiogo @olizilla @hacdias