-
Notifications
You must be signed in to change notification settings - Fork 17
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Rename to dag-service #381
Conversation
LICENSE
Outdated
|
||
Copyright (c) 2020 Protocol Labs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this cool ? Do we need to do extra steps ?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, since there are multiple contributors involved here, we might need to have this as something more like:
Copyright (c) 2020 Project contributors
But I'm not all that well-versed in the potential issues here. Maybe @andrewxhill has some thoughts?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
nothing from me, no pref
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM. I left one or two comments, and would like some feedback from others re: copy-write as I'm less familiar with these types of things.
LICENSE
Outdated
|
||
Copyright (c) 2020 Protocol Labs |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hmmm, since there are multiple contributors involved here, we might need to have this as something more like:
Copyright (c) 2020 Project contributors
But I'm not all that well-versed in the potential issues here. Maybe @andrewxhill has some thoughts?
Co-authored-by: Carson Farmer <carson.farmer@gmail.com>
Should be dual Apache2 & MIT https://protocol.ai/blog/announcing-the-permissive-license-stack/ |
Update pull request to change to dual license and created an issue to request signoffs to do so #382 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
OK, looks like there are no further changes/discussion required. Let's do it.
Description
Renames the project to js-dag-service
Fixes #336