Skip to content
This repository has been archived by the owner on Mar 10, 2020. It is now read-only.

Make ipfs.files.add return DAGNodes. #281

Closed
wants to merge 6 commits into from

Conversation

hackergrrl
Copy link
Contributor

@hackergrrl hackergrrl commented May 24, 2016

  • do an object lookup to transform objects to DAGNodes
  • break out local file adding and url adding to separate methods
  • use + pass interface-ipfs-core tests for files.add
  • add tests to get merged into interface-ipfs-core and published

NOTE: this breaks backwards compatibility for add and will require a major semver bump.

@hackergrrl
Copy link
Contributor Author

Just waiting on ipfs-inactive/interface-js-ipfs-core#20 to get merged + published and we're good to go!

@daviddias daviddias mentioned this pull request Jun 5, 2016
@daviddias
Copy link
Contributor

closing in favor of #288

@daviddias daviddias closed this Jun 5, 2016
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants