Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

add http resource, files core upgrades, cat cli upgrades, add/cat interface-core integration #256

Closed
wants to merge 5 commits into from

Conversation

nginnever
Copy link
Member

@nginnever nginnever commented May 23, 2016

PR Check List.

The interface-core tests will cause errors until the PR's listed are finalized. The js-ipfs core tests are currently running from the interface-core cat PR.

What's done:

  • add http resource closes PR
  • add cli test
  • add cli daemon on
  • cat cli upgrade
  • cat core upgrade closes PR
  • alias for js-ipfs-api cat`` and ``add

What needs to be done:

  • use interface core tests needs
    • cat tests/spec PR
    • add tests/spec PR
    • cat js-ipfs-api - interface core tests PR
    • add js-ipfs-api - interface core tests PR

@jbenet jbenet added the status/in-progress In progress label May 23, 2016
@nginnever nginnever changed the title add http resource, files core upgrades, cat cli upgrades, begin interface-core integration add http resource, files core upgrades, cat cli upgrades, add/cat interface-core integration May 25, 2016
@nginnever
Copy link
Member Author

The requirements for this PR have been met but a lot has changed in the course of that. Will update accordingly soon.

@daviddias
Copy link
Member

daviddias commented Jun 7, 2016

@nginnever stripped out the cat implementation to be merged here #316 (since this PR has many things that js-ipfs already has)

Two things missing

  • tests and impl for
    • add through http-api
    • cat through http-api

@nginnever
Copy link
Member Author

add http continued on #323

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants