feat: add unwantBlocks method #10
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| return done(err) | ||
| this.getBlocks([key], (errs, res) => { | ||
| if (errs) { | ||
| return done(errs[0]) |
There was a problem hiding this comment.
What about all the other errs?
There was a problem hiding this comment.
Maybe do like the block-service? Where getBlocks returns an object of mutlihash: { err, block}
There was a problem hiding this comment.
There should be max one error here, but could do the object approach
There was a problem hiding this comment.
@diasdavid done, please give this another round of review so I can merge it soon :)
dignifiedquire
force-pushed
the
feat/unwantBlocks
branch
from
a1cede0
to
8bfbb20
Compare
17 tasks
| Fetch multiple blocks. The `cb` is called with a result object of the form | ||
| ```js | ||
| { | ||
| [key1]: {error: errorOrUndefined, block: blockOrUndefined}, |
There was a problem hiding this comment.
"key being the multihash of the block"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.