This repository has been archived by the owner on Oct 1, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 3
feat: add migration 9 to migrate pins to the datastore and back #15
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Stores pins in the datastore for greatly increased speed of access. Borrows the pin-set code from js-ipfs to perform the reverse migration.
5 tasks
vasco-santos
approved these changes
Jul 16, 2020
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Overall looks good to me!
I could not find clear documents on what should be included in the migration, but the code looks good
@vasco-santos there's more discussion on ipfs/js-ipfs#2771 |
I would only suggest to add informations about migrations into the Migration matrix, that I can see was not added for the 8th migration as well: https://github.com/ipfs/js-ipfs-repo-migrations#migrations-matrix |
And feel free to "kick me out" of the Lead Maintaining of this repo 😉 |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Stores pins in the datastore for greatly increased speed of access.
Borrows the pin-set code from js-ipfs to perform the reverse migration.