Skip to content
This repository has been archived by the owner on Oct 1, 2021. It is now read-only.

feat: add migration 9 to migrate pins to the datastore and back #15

Merged
merged 10 commits into from
Jul 21, 2020

Conversation

achingbrain
Copy link
Member

Stores pins in the datastore for greatly increased speed of access.

Borrows the pin-set code from js-ipfs to perform the reverse migration.

Stores pins in the datastore for greatly increased speed of access.

Borrows the pin-set code from js-ipfs to perform the reverse migration.
@jacobheun jacobheun requested a review from vasco-santos July 16, 2020 14:47
Copy link
Member

@vasco-santos vasco-santos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall looks good to me!
I could not find clear documents on what should be included in the migration, but the code looks good

@achingbrain
Copy link
Member Author

@vasco-santos there's more discussion on ipfs/js-ipfs#2771

@AuHau
Copy link
Member

AuHau commented Jul 17, 2020

I would only suggest to add informations about migrations into the Migration matrix, that I can see was not added for the 8th migration as well: https://github.com/ipfs/js-ipfs-repo-migrations#migrations-matrix

@AuHau
Copy link
Member

AuHau commented Jul 17, 2020

And feel free to "kick me out" of the Lead Maintaining of this repo 😉

@achingbrain achingbrain merged commit 2b14578 into master Jul 21, 2020
@achingbrain achingbrain deleted the feat/migrate-pins-to-datastore branch July 21, 2020 09:43
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants