This repository has been archived by the owner on Oct 1, 2021. It is now read-only.
fix: remove node globals #6
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This PR add new datastore for browser and remove node glovals Plus
56 tasks
AuHau
approved these changes
Apr 1, 2020
|
it shouldn’t, do we have any tests for that ? |
|
Nope, this tool depends on the datastore abstraction and this abstraction is not tested here. I am not following |
|
backend is the same its just removing one abstraction layer, but still we should keep snapshots to be able to test this type of stuff |
|
Hmmm I am not really sure what or how to test for this. I mean we can test the abstraction, but I don't think this is the place to do it. Do you have a proposal what exactly to test and how? |
achingbrain
approved these changes
Apr 14, 2020
AuHau
approved these changes
Apr 14, 2020
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR add new datastore for browser and removes node globals.
Also opens datastore in several places!