Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: keys is a standard interface-datastore #156

Merged
merged 2 commits into from
Dec 11, 2017
Merged

fix: keys is a standard interface-datastore #156

merged 2 commits into from
Dec 11, 2017

Conversation

richardschneider
Copy link
Contributor

copy and paste error

@ghost ghost assigned richardschneider Dec 7, 2017
@ghost ghost added the status/in-progress In progress label Dec 7, 2017
@richardschneider
Copy link
Contributor Author

@victorbjelkholm Jenkins is failing with a strange error. All other CIs are happy. See https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs-repo/detail/PR-156/1/pipeline

@richardschneider richardschneider mentioned this pull request Dec 7, 2017
Merged
6 tasks
daviddias
daviddias requested changes Dec 7, 2017
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@richardschneider could you add a test?

@richardschneider
Copy link
Contributor Author

@diasdavid added the test

@richardschneider
Copy link
Contributor Author

@diasdavid LGTM

@richardschneider richardschneider mentioned this pull request Dec 10, 2017
Merged
@daviddias daviddias merged commit d99f3c4 into master Dec 11, 2017
@ghost ghost removed the status/in-progress In progress label Dec 11, 2017
@daviddias daviddias deleted the keys branch December 11, 2017 17:57
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@daviddias daviddias daviddias approved these changes

Assignees

@richardschneider richardschneider

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@richardschneider @daviddias