feat: store blocks under multihash key #211
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
AuHau
force-pushed
the
auhau/feat/multihash_keys_in_datastore
branch
2 times, most recently
from
08507bd
to
c9128c5
Compare
AuHau
force-pushed
the
auhau/feat/multihash_keys_in_datastore
branch
2 times, most recently
from
c5405d1
to
79245d4
Compare
9 tasks
AuHau
force-pushed
the
auhau/feat/multihash_keys_in_datastore
branch
from
79245d4
to
969f41a
Compare
Sounds about right! :) Good catch! |
|
@daviddias alright, but then what about the |
AuHau
force-pushed
the
auhau/feat/multihash_keys_in_datastore
branch
from
969f41a
to
a697b5e
Compare
achingbrain
force-pushed
the
auhau/feat/multihash_keys_in_datastore
branch
6 times, most recently
from
71503ac
to
ca2cdf1
Compare
Integration of js-ipfs-repo-migrations brings automatic repo migrations
to ipfs-repo (both in-browser and fs). It is possible to control the
automatic migration using either config's setting
'repoDisableAutoMigration' or IPFSRepo's option 'disableAutoMigration'.
BREAKING CHANGE: repo.blocks.query() now returns multihashes as a key
instead of CID. If you want to have CID returned call it as query({},
true), which will constructs CIDv1 using IPLD's RAW codec. This means
that this constructed CID might not equal to the one that the block was originally
saved. Related to ipfs/js-ipfs#2415
Co-authored-by: achingbrain <alex@achingbrain.net>
achingbrain
force-pushed
the
auhau/feat/multihash_keys_in_datastore
branch
from
ca2cdf1
to
6c5e171
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is related to ipfs/js-ipfs#2415
Breaking change
repo.blocks.query()now returns multihashes as a key instead of CID.Question!
repo.blocks.query()currently returns Datastore's query object (eq.{key: '', value: ''}). Shouldn't it returnjs-ipfs-block's Block instead? All otherrepo.blocksfunctions return Block... As I will be refactoring all usages ofrepo.blocks.query()this might be good oportunity to change it.Yet if we would do it, we would have to reconstruct the CID using IPLD RAW codec. This will be generally desired behavior of the
query()function anyway (there is already implemented behavior for this, but is used only when called asquery({}, true)).But on the other hand not sure how we would handle the case when
query()would be called with for examplerepo.blocks.query({keysOnly: true})...