Running the tests in the browser #26
Conversation
|
Let's finish this up today after ArcticJS talks :) |
daviddias
changed the title
| }).end(file.value, cb) | ||
| }, () => { | ||
| // FIXME debuging possible idb-blob-store bug | ||
| setTimeout(done, 1000) |
There was a problem hiding this comment.
This line was added for testing purposes.
It seems that the end event on the returned write streams is emitted before it actually finishes, making the testes fail, since the db isn't consistent.
There was a problem hiding this comment.
Is this still required with local-storage-blob-store?
There was a problem hiding this comment.
Nope, just removed the setTimeout
fbaiodias
force-pushed
the
browser
branch
4 times, most recently
from
c6dbe96
to
bbb1e3c
Compare
| repo.datastore.createReadStream(buf) | ||
| .pipe(bl((err, data) => { | ||
| expect(err).to.not.exist | ||
| const eq = fs.readFileSync(process.cwd() + '/tests/test-repo/blocks/12207028/122070286b9afa6620a66f715c7020d68af3d10e1a497971629c07606bfdb812303d.data').equals(data) |
There was a problem hiding this comment.
Can you brfs this file so that the test also works in the browser?
fbaiodias
force-pushed
the
browser
branch
3 times, most recently
from
9149447
to
cbc223d
Compare
| singleRun: true, | ||
|
|
||
| // List plugins explicitly, since autoloading karma-webpack | ||
| // won't work here |
There was a problem hiding this comment.
why? this should work if they are listed in package.json
There was a problem hiding this comment.
first time using karma, just removed that :)
|
I can try running it later. please let me know if you made progress so I don't do things twice |
|
@xicombd, can you check @dignifiedquire comments and adjust to those? |
|
Cleared all my confusions and running well on my machine, just left some notes about things that could be improved |
Yes, on it right now. @dignifiedquire: everything is working now, the problems I was having were apparently related to |
|
🎉🎉🎉🎉 Thank you for finishing this @xicombd :) |
Running the tests in the browser
Hey!
I'm trying to get the repo running on a browser, but I'm having some trouble doing it, so a review would be appreciated :)
I started by specifying two different entry points on
package.json, one for now which usesfs-blob-storeas before and one for the browser which usesidb-blob-store.I've also started setting up karma for running the tests, however they're currently very slow and inconsistent, having different results on different runs, but I haven't really understood why.
Please let me know if you find anything