fix: OOM on large DAGs #410
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Storing a set of seen CIDs to short-cut DAG traversal while ensuring we have all the blocks in a DAG in the blockstore can cause OOMs for very large DAGs.
|
How easy is it to add a regression test? |
|
The optimisation is now retained but we use a LRU cache instead of an unbounded Set. |
Refactor to use a lru cache instead of an unbounded set and add a test to make sure the cache actually caches things.
|
🎉 This PR is included in version ipfs-repo-migrations-v13.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
github-actions bot
pushed a commit
that referenced
this pull request
Sep 21, 2022
## [ipfs-repo-v15.0.3](ipfs-repo-v15.0.2...ipfs-repo-v15.0.3) (2022-09-21) ### Bug Fixes * OOM on large DAGs ([#410](#410)) ([336d0b9](336d0b9))
|
🎉 This PR is included in version ipfs-repo-v15.0.3 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Storing a set of seen CIDs to short-cut DAG traversal while ensuring we have all the blocks in a DAG in the blockstore can cause OOMs for very large DAGs so replace the unbounded
Setwith aLRUcache with a configurable maximum size.