Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: follow abstract-blob-store interface for exists calls #59

Merged
merged 1 commit into from
May 5, 2016
Merged

fix: follow abstract-blob-store interface for exists calls #59

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 1 addition & 7 deletions src/index.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,13 +30,7 @@ function Repo (repoPath, options) {
.setUp(repoPath, options.stores.locks)

this.exists = (callback) => {
this.version.exists((err, exists) => {
if (err) {
callback(new Error('repo does not exist'), false)
} else {
callback(null, exists)
}
})
this.version.exists(callback)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

perhaps this.exists = this.version.exists.bind(this) ?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

or we could do this.exists = (cb) => this.version.exists(cb) ;)

Not sure tbh if there is a big difference between those but can do

}

this.version = stores
Expand Down