Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: switch to protobuf.js #18

Closed
wants to merge 4 commits into from
Closed

Conversation

dignifiedquire
Copy link
Member

no more eval

Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

If we are building on release, we probably don't want to commit the built version. Could you .gitignore it?

@dignifiedquire
Copy link
Member Author

we still want to commit it as otherwise installs from github will be broken

@daviddias
Copy link
Member

Fair, then the other 2 PR also need it commited

@dignifiedquire
Copy link
Member Author

but I realised we should not auto build on releae, this file should not change most of the time, only when manipulating the proto file, so I will remove that

@dignifiedquire
Copy link
Member Author

@diasdavid pushed fixes to all three PRs

@daviddias
Copy link
Member

@dignifiedquire did you see this:

image

Shouldn't coverage be ignoring the protobuf file?

@daviddias
Copy link
Member

daviddias commented Sep 5, 2017

Same issue in ipld/js-ipld-dag-pb#40 but interestingly not in libp2p/js-libp2p-crypto#107

@dignifiedquire
Copy link
Member Author

coverage fix coming

@dignifiedquire dignifiedquire deleted the fix/better-proto branch September 7, 2017 08:36
achingbrain added a commit that referenced this pull request Feb 19, 2020
* fix: increase test timeouts for sharding
achingbrain added a commit that referenced this pull request Feb 19, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants