-
Notifications
You must be signed in to change notification settings - Fork 35
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: switch to protobuf.js #18
Conversation
no more eval
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
If we are building on release, we probably don't want to commit the built version. Could you .gitignore it?
we still want to commit it as otherwise installs from github will be broken |
Fair, then the other 2 PR also need it commited |
but I realised we should not auto build on releae, this file should not change most of the time, only when manipulating the proto file, so I will remove that |
@diasdavid pushed fixes to all three PRs |
@dignifiedquire did you see this: Shouldn't coverage be ignoring the protobuf file? |
Same issue in ipld/js-ipld-dag-pb#40 but interestingly not in libp2p/js-libp2p-crypto#107 |
coverage fix coming |
* fix: increase test timeouts for sharding
no more eval