feat: store time as timespec #40
Conversation
To allow high resolution `mtime`, store time as `TimeSpec` message which contains seconds and nanosecond fragments. Also allows passing `mtime` and `mode` in multiple formats, fixes coverage npm script and increases module test coverage.
|
CC @ribasushi |
|
What is TimeSpec? |
It's a Protobuf Message that allows us to store high resolution |
Allow 0-999.. but only marshal 1-999..
| } | ||
|
|
||
| if (mtime.nsecs < 0 || mtime.nsecs > 999999999) { | ||
| throw errcode(new Error('mtime-nsecs must be within the range [0,999999999]'), 'ERR_INVALID_MTIME_NSECS') |
There was a problem hiding this comment.
@achingbrain what did we decide on the range? Your thumbs up at ipfs/specs#236 (comment) seems to indicate you agreed with [1,999999999]...
There was a problem hiding this comment.
This PR is lagging a little behind the spec discussion.
That said, I think we can reject (or omit) 0 as a nanosecond value when serializing to a protobuf but accept it at this level as a nicety to the developer.
Be liberal in what you accept and conservative in what you send, etc, etc.
There was a problem hiding this comment.
For example, if the user passes the output of process.hrtime() as the mtime (e.g. [secs, nsecs] and it just so happens to fall exactly on the second with a 0 nanosecond fragment, it seems silly to reject the value as it creates a really subtle timing bug.
Instead we can just Do The Right Thing and omit the 0 value when writing out to a protobuf.
There was a problem hiding this comment.
@achingbrain on the user-facing API side: I absolutely agree. Whenever I say "reject" I mean in the cases when a block is being decoded.
I.e. I make a distinction between "developer is constructing stuff to send to the network" and "we are decoding stuff we received from the network"
The `pending` array is emptied every iteration so just pass the file chunk directly into the rabin chunker instead.
To allow high resolution
mtime, store time asTimeSpecmessage which contains seconds and nanosecond fragments.Also allows passing
mtimeandmodein multiple formats,defaults, fixes coverage npm script and increases module test coverage.mtimeto the epochDepends on: