Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: do not use electron-fetch types #113

Merged
merged 4 commits into from
Apr 1, 2021

Conversation

achingbrain
Copy link
Member

Use our imaginary native-fetch types instead as they do not require
consuming modules to also depend on electron-fetch.

Use our imaginary native-fetch types instead as they do not require
consuming modules to also depend on electron-fetch.
@achingbrain achingbrain requested a review from hugomrdias April 1, 2021 16:57
@achingbrain
Copy link
Member Author

Can probably remove the util dev dep when Gozala/web-encoding#19 is resolved.

@achingbrain achingbrain merged commit 658a725 into master Apr 1, 2021
@achingbrain achingbrain deleted the fix/types-do-not-use-electron-fetch-types branch April 1, 2021 18:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant