-
Notifications
You must be signed in to change notification settings - Fork 30
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: swap @yields for @returns #178
Conversation
Thank you for submitting this PR!
Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution. |
This reverts commit f80ae70.
### [9.0.6](v9.0.5...v9.0.6) (2022-04-19) ### Bug Fixes * swap [@yields](https://github.com/yields) for [@returns](https://github.com/returns) ([#178](#178)) ([13e2c9b](13e2c9b))
🎉 This PR is included in version 9.0.6 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Motivation:
import globSourceImport from 'ipfs-utils/src/files/glob-source.js'
from typescriptContext:
Strategy
@return
instead of@yields
because tsc doesn't understand that@yields
implies a@return
typeTest Case
npm link
and this seemed to fix it