Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: avoid Identifier 'global' has already been declared #30

Merged
merged 1 commit into from
Apr 6, 2020
Merged

fix: avoid Identifier 'global' has already been declared #30

merged 1 commit into from
Apr 6, 2020

Conversation

bluelovers
Copy link
Contributor

@bluelovers bluelovers commented Mar 31, 2020 •
edited by lidel
Loading

Closes #29

@lidel lidel requested a review from hugomrdias April 4, 2020 19:05
@bluelovers bluelovers mentioned this pull request Apr 4, 2020
Closed
lidel
lidel approved these changes Apr 4, 2020
View reviewed changes
Copy link
Member

@lidel lidel left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this will unblock ipfs-webui to switch to the latest ipfs-http-client.
Right now jest tests fail as described in #29

@hugomrdias hugomrdias merged commit f468065 into ipfs:master Apr 6, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lidel lidel lidel approved these changes

@hugomrdias hugomrdias Awaiting requested review from hugomrdias

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Identifier 'global' has already been declared when run with jest
3 participants
@bluelovers @lidel @hugomrdias