feat: support blobs, file objects, iterators and async iterators #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to accept async interators as arguments to ipfs.add and friends. It also allows adding plain old js things like strings and arrays, so hooray for that.
|
I don't really know if this function is even necessary any more. The input normalisation function in #5 will throw errors if it encounters invalid input, and is also smart enough to do it to the contents of (async) iterators too, so doing this sort of up-front exception doesn't give us much except the possibility of failing fast on a limited subset of inputs. |
|
Should we remove this once #5 is merged ? |
|
I don't think this is necessary any more. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This allows us to accept async iterators as arguments to ipfs.add and friends.
It also allows adding plain old js things like strings and arrays, so hooray for that.