feat: add types, gh actions and remove unused methods #89
Conversation
these were copied to ipfs-core-utils
not needed anymore
|
|
||
| // validate resource type | ||
| if (typeof resource !== 'string' && !(resource instanceof URL || resource instanceof Request)) { | ||
| throw new TypeError('`resource` must be a string, URL, or Request') | ||
| } | ||
|
|
||
| // validate resource format and normalize with prefixUrl |
There was a problem hiding this comment.
Is this not needed anymore?
There was a problem hiding this comment.
URL below this line does the job
There was a problem hiding this comment.
Thanks @hugomrdias for your hard work, this is a lot. I have suggested some improvements that I think would be worth incorporating & also nit picked a bit, but feel free to ignore those.
| path: string; | ||
| content?: AsyncIterable<Uint8Array>; | ||
| }>} | ||
| */ |
There was a problem hiding this comment.
This reminds me, we really should make this return a Promise<{path: string, content:AsyncIterable<Uint8Array>}> instead (see #53)
| } | ||
|
|
||
| if (opts.json !== undefined) { | ||
| if (json) { |
There was a problem hiding this comment.
null is valid JSON, which would have worked without this change.
| ...options, | ||
| method: 'POST' | ||
| }) | ||
| return this.fetch(resource, { ...options, method: 'POST' }) |
There was a problem hiding this comment.
Nit: I think line breaks are good, as they cause less noise when adding or removing an option.
| @@ -166,71 +166,56 @@ class HTTP { | |||
| } | |||
|
|
|||
| /** | |||
| * @param {string | URL | Request} resource | |||
| * @param {APIOptions} options | |||
| * @param {string | Request} resource | |||
There was a problem hiding this comment.
Nit: I think supporting URL instances is a good idea, as unlike strings they do represent valid urls.
| @@ -0,0 +1 @@ | |||
| export { URL, URLSearchParams } | |||
There was a problem hiding this comment.
hmm, I thought TS did not liked exports of things that aren't defined locally.
There was a problem hiding this comment.
our config has the browser/dom stuff
BREAKING CHANGE: removed globalThis and normalise-input, format-mode and format-mtime