Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add React Native (iOS and Android) support #91

Merged
merged 18 commits into from
May 21, 2021

Conversation

acostalima
Copy link
Contributor

@acostalima acostalima commented Jan 31, 2021

TODO

  • Add types for react-native-fetch-api
  • Integrate rn-test with aegir to run tests for both iOS and Android
  • Finish CI and setup and ensure it runs to completion successfully

NOTE: React Native does not support ReadableStream for request bodies. However, just like the browser, we can use XMLHttpRequest.upload.onprogress event as a workaround.

@hugomrdias, can you give me a hand on items above? 🙏

Depends on hugomrdias/iso-url#154

@welcome
Copy link

welcome bot commented Jan 31, 2021

Thank you for submitting this PR!
A maintainer will be here shortly to review it.
We are super grateful, but we are also overloaded! Help us by making sure that:

  • The context for this PR is clear, with relevant discussion, decisions
    and stakeholders linked/mentioned.

  • Your contribution itself is clear (code comments, self-review for the
    rest) and in its best form. Follow the code contribution
    guidelines

    if they apply.

Getting other community members to do a review would be great help too on complex PRs (you can ask in the chats/forums). If you are unsure about something, just leave us a comment.
Next steps:

  • A maintainer will triage and assign priority to this PR, commenting on
    any missing things and potentially assigning a reviewer for high
    priority items.

  • The PR gets reviews, discussed and approvals as needed.

  • The PR is merged by maintainers when it has been approved and comments addressed.

We currently aim to provide initial feedback/triaging within two business days. Please keep an eye on any labelling actions, as these will indicate priorities and status of your contribution.
We are very grateful for your contribution!

@acostalima acostalima changed the title Add React Native support Add React Native (iOS and Android) support Feb 1, 2021
package.json Outdated Show resolved Hide resolved
src/text-encoder.js Outdated Show resolved Hide resolved
@acostalima
Copy link
Contributor Author

Without aegir integration, tests can be run with the following commands:

$ node .aegir.js & # with the temporary changes introduced to start the echo server without aegir
$ AEGIR_RUNNER=react-native ECHO_SERVER=http://localhost:3000 npx rn-test --platform ios --simulator 'iPhone 11 (14.1)' 'test/**/*.spec.js'

@acostalima acostalima force-pushed the feat/add-react-native branch 4 times, most recently from f559f98 to 661b064 Compare March 4, 2021 18:55
@hugomrdias hugomrdias self-assigned this May 21, 2021
@hugomrdias hugomrdias marked this pull request as ready for review May 21, 2021 14:20
@hugomrdias hugomrdias merged commit b2b02a5 into ipfs:master May 21, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants