This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
Repo interop tests failing due to different repo versions #1059
Labels
kind/bug
A bug in existing code (including security flaws)
Comments
|
@dryajov you should be able to update the repo version in js-ipfs-repo |
MicrowaveDev
pushed a commit
to galtproject/js-ipfs
that referenced
this issue
May 22, 2020
This PR enabled pubsub in the browser and paves the way for a switch to using `fetch` by default and allowing for cancelable requests via the use of `AbortController`. It's mostly the work done in ipfs-shipyard/js-ipfs-http-client-lite#1 but adapted a bit for use here. If approved, we can start work moving the other commands to use `fetch`. The work in https://github.com/ipfs-shipyard/js-ipfs-http-client-lite has proven the hard parts (uploading files) are all possible using the `fetch` API. Since `fetch` is promise based, when moving the other commands it makes sense to just switch to async/await as per ipfs#1670 (and callbackify instead of promisify). Depends on: * [x] ipfs-inactive/interface-js-ipfs-core#505 resolves ipfs-inactive/js-ipfs-http-client#518 refs ipfs#2093 resolves ipfs-inactive/js-ipfs-http-client#932 License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Type: Bug
Severity: High
Description: Repo interop tests failing because of differences in repo versions
Steps to reproduce the error:
npm run test:interopThe text was updated successfully, but these errors were encountered: