-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: make js-ipfs cli and daemon behave like go-ipfs #1067
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@dryajov could you please add a test to this PR?
will do! |
b1e8d36
to
66bc4e1
Compare
Added |
(test are on the way) |
EDIT: this is resolved. I've added the test for missing Addresses.Swarm, but I'm running into a weird error. When passing my configuration with the
essentially failing to deserialize Addresses.API as an array. I'm not sure what the issue might be. This has definitely left me head scratching - need to investigate some more. (it might also be the consequence of working at 5am 👅 ) |
all issues resolved and tests added. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @dryajov :)
This is needed to make js-ipfs consistent with how go-ipfs behaves - needed for ipfs/js-ipfsd-ctl#170.