Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[WIP] feat: add ability to start js-ipfs nodes #170

Closed
wants to merge 5 commits into from

Conversation

dryajov
Copy link
Member

@dryajov dryajov commented Nov 11, 2017

This depends on - ipfs/js-ipfs#1067

package.json Outdated
"release": "aegir release -t node",
"release-minor": "aegir release --type minor -t node",
"release-major": "aegir release --type major -t node",
"coverage-publish": "aegir coverage -u"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please make an aegir upgrade be part of a separate PR

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

kk, will pull aegir out.

@daviddias daviddias mentioned this pull request Nov 12, 2017
@dryajov dryajov force-pushed the feat/support-js branch 2 times, most recently from 4d814b1 to ec8de2a Compare November 13, 2017 11:54
@dryajov dryajov changed the title [WIP] feat: add ability to start js-ipfs nodes [WIP] make js-ipfs cli and daemon behave lie go-ipfs Nov 13, 2017
@dryajov dryajov changed the title [WIP] make js-ipfs cli and daemon behave lie go-ipfs [WIP] make js-ipfs cli and daemon behave like go-ipfs Nov 13, 2017
@dryajov dryajov changed the title [WIP] make js-ipfs cli and daemon behave like go-ipfs [WIP] feat: add ability to start js-ipfs nodes Nov 13, 2017
@dryajov
Copy link
Member Author

dryajov commented Nov 22, 2017

this depends on ipfs/js-ipfs#1095 now.

// fails on windows see https://github.com/ipfs/js-ipfs-api/issues/408
if (isWindows) {
return it.skip('uses the correct ipfs-api')
}
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This skip has been removed in 381ac1c, you may have to rebase https://github.com/ipfs/js-ipfsd-ctl/network

@daviddias
Copy link
Member

Is this still needed with #176 ?

@dryajov
Copy link
Member Author

dryajov commented Dec 14, 2017

this is not needed anymore - closing.

@dryajov dryajov closed this Dec 14, 2017
@ghost ghost removed the status/in-progress In progress label Dec 14, 2017
@daviddias daviddias deleted the feat/support-js branch December 15, 2017 06:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants