Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Docs: Explain that "Interval" value in MDNS config options is seconds #1123

Closed
haadcode opened this issue Dec 2, 2017 · 2 comments
Closed

Docs: Explain that "Interval" value in MDNS config options is seconds #1123

haadcode opened this issue Dec 2, 2017 · 2 comments
Labels
kind/support A question or request for support status/ready Ready to be worked topic/docs Documentation

Comments

@haadcode
Copy link
Member

haadcode commented Dec 2, 2017

Not sure where to do this, but we should document the MDNS "Interval" option that it is in seconds. I've always thought it's milliseconds:
https://github.com/ipfs/js-ipfs/blob/master/src/core/runtime/config-nodejs.json#L13

Would be happy to PR this if someone can tell where we should do this :)
@haadcode haadcode added the kind/support A question or request for support label Dec 2, 2017
@deltab
Copy link

deltab commented Dec 3, 2017

How about including it in the name, as "IntervalSeconds"?

@daviddias daviddias added the status/deferred Conscious decision to pause or backlog label Jan 25, 2018
@richardschneider richardschneider mentioned this issue Feb 3, 2018
Open
@daviddias daviddias added status/ready Ready to be worked and removed status/deferred Conscious decision to pause or backlog labels Dec 9, 2018
@daviddias daviddias added the topic/docs Documentation label Oct 1, 2019
MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this issue May 22, 2020
@achingbrain
feat: adds ipfs.block.rm method (ipfs#1123)
2f0eff7 
* feat: adds ipfs.block.rm method
* chore: fix up interface tests
@achingbrain
Copy link
Member

This is documented as being in seconds - https://github.com/ipfs/js-ipfs/blob/master/docs/CONFIG.md#mdns

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
kind/support A question or request for support status/ready Ready to be worked topic/docs Documentation
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@achingbrain @daviddias @deltab @haadcode