Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Buffer@6.x.x has caused the http client bundle size to increase #3604

Closed
5 of 10 tasks
achingbrain opened this issue Apr 1, 2021 · 1 comment
Closed
5 of 10 tasks
Assignees
Labels
kind/not-helia-issue kind/tracking A meta-issue for tracking work status/in-progress In progress

Comments

@achingbrain
Copy link
Member

achingbrain commented Apr 1, 2021

There was a new semver major Buffer release which has caused lots of duplication in the browser bundles, particularly the http client.

This should be resolved before the next release.

Instances of

./node_modules/borc/node_modules/buffer
./node_modules/it-ws/node_modules/buffer
./node_modules/it-buffer/node_modules/buffer
./node_modules/bl/node_modules/buffer
./node_modules/abstract-leveldown/node_modules/buffer
./node_modules/it-to-stream/node_modules/buffer
./node_modules/iso-random-stream/node_modules/buffer
./node_modules/it-length-prefixed/node_modules/buffer
./node_modules/level-js/node_modules/buffer
./node_modules/it-tar/node_modules/buffer
./node_modules/it-multipart/node_modules/buffer
./node_modules/it-goodbye/node_modules/buffer
./node_modules/level-codec/node_modules/buffer
./node_modules/it-to-buffer/node_modules/buffer
./node_modules/buffer

PRs:

@achingbrain achingbrain added the kind/tracking A meta-issue for tracking work label Apr 1, 2021
@achingbrain achingbrain added the status/in-progress In progress label Apr 1, 2021
achingbrain added a commit that referenced this issue Apr 1, 2021
Updates deps to pull in Buffer@6.x.x

Refs #3604
achingbrain added a commit that referenced this issue Apr 9, 2021
Updates deps to pull in Buffer@6.x.x

Refs #3604
achingbrain added a commit that referenced this issue Apr 27, 2021
Updates deps to pull in Buffer@6.x.x

Refs #3604
Fixes #3389

Co-authored-by: Vasco Santos <vasco.santos@moxy.studio>
SgtPooki referenced this issue in ipfs/js-kubo-rpc-client Aug 18, 2022
Updates deps to pull in Buffer@6.x.x

Refs #3604
Fixes #3389

Co-authored-by: Vasco Santos <vasco.santos@moxy.studio>
@whizzzkid whizzzkid assigned achingbrain and unassigned whizzzkid May 23, 2023
@SgtPooki
Copy link
Member

js-ipfs is being deprecated in favor of Helia. You can #4336 and read the migration guide.

Please feel to reopen with any comments by 2023-06-02. We will do a final pass on reopened issues afterward (see #4336).

It looks like all the PRs were merged and this should not be an issue with the latest js-ipfs packages.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
kind/not-helia-issue kind/tracking A meta-issue for tracking work status/in-progress In progress
Projects
No open projects
Status: Done
Status: Done
Development

No branches or pull requests

3 participants