Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix build on nodejs stable - update hapi when it is released #541

Closed
dignifiedquire opened this issue Oct 25, 2016 · 7 comments
Closed

fix build on nodejs stable - update hapi when it is released #541

dignifiedquire opened this issue Oct 25, 2016 · 7 comments
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws)

Comments

@dignifiedquire
Copy link
Member

os.tmpDir was deprecated in favor of os.tmpdir, resulting in failing tests on CI as we are checking against console output in our tests.

see https://travis-ci.org/ipfs/js-ipfs/jobs/170467892
@dignifiedquire dignifiedquire added kind/bug A bug in existing code (including security flaws) exp/novice Someone with a little familiarity can pick up help wanted Seeking public contribution on this issue labels Oct 25, 2016
@victorb
Copy link
Member

victorb commented Oct 25, 2016

Not sure a deprecation warning should break are tests here, but I do agree we should change it.

The error is a bit weird though.

AssertionError: expected '(node:3832) DeprecationWarning: os.tmpDir() is deprecated. Use os.tmpdir() instead.' to deeply equal ''

Why would we check that the output is "deeply equal" to empty string? Not sure if it's the test cases that are bad, or just printing of the error, but something is wrong here.

@dignifiedquire
Copy link
Member Author

@victorbjelkholm the checks do make sense as it is testing the cli interface and checking stdout is the way to do it. Similar many of the sharness tests will run into this.

@victorb
Copy link
Member

victorb commented Oct 25, 2016

@dignifiedquire checking that there is no output doesn't feel like a very stable way of testing a CLI. Maybe we could turn on verbose/debug output and make assertions on that?

@daviddias
Copy link
Member

@victorbjelkholm the other we test it is with sharness, any other way you would recommend?

@daviddias
Copy link
Member

I'm trying to see where the os.tmpdir is being called? But the Silver Searcher is not saving this world from getting devoured

@dignifiedquire
Copy link
Member Author

Fixed but not released in hapijs: hapijs/hapi#3368

@dignifiedquire dignifiedquire removed the help wanted Seeking public contribution on this issue label Oct 31, 2016
@daviddias daviddias changed the title fix build on nodejs stable fix build on nodejs stable - update hapi when it is released Nov 12, 2016
@daviddias
Copy link
Member

-> #603

MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this issue May 22, 2020
@hugomrdias
feat: add support for new ipfsd-ctl (ipfs#541)
a27cfa7 
* feat: add support for a simpler and async test setup

* fix: tweak some tests

* fix: fix connecting multiples node in the browser

when running with a 'proc' pre-setup we could end up with multiples in-browser setup connecting to each other. whihc isnt a very useful situation.
with this the first node gets the pre-configured config and all the others get a JS daemon.

* fix: change secondary node to Go

* fix: one more to go

* chore: update to the latest ctl api

* fix: add connect to wantlist tests

* fix: fix pubsub tests in firefox

* fix: increase timeout findprovs

* fix: revert pubsub to go

* fix: add more info

* chore: bump ipfsd-ctl
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Assignees
No one assigned
Labels
exp/novice Someone with a little familiarity can pick up kind/bug A bug in existing code (including security flaws)
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@victorb @dignifiedquire @daviddias