Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: progress bar flakiness #1042

Merged
merged 2 commits into from
Oct 20, 2017
Merged

fix: progress bar flakiness #1042

merged 2 commits into from
Oct 20, 2017

Conversation

dryajov
Copy link
Member

@dryajov dryajov commented Oct 19, 2017

this resolves #1041

@dryajov dryajov changed the title fix: fix progress bar flakiness [WIP] fix: fix progress bar flakiness Oct 19, 2017
@ghost ghost assigned dryajov Oct 20, 2017
@ghost ghost added the status/in-progress In progress label Oct 20, 2017
@dryajov dryajov changed the title [WIP] fix: fix progress bar flakiness fix: progress bar flakiness Oct 20, 2017
@dryajov
Copy link
Member Author

dryajov commented Oct 20, 2017

We I still need to address the sec vulnerability here.

@dryajov
Copy link
Member Author

dryajov commented Oct 20, 2017

@diasdavid This is going to be blocked until browserify/static-module#35 (or similar) is merged, we then need to propagate those changes over the dependency tree.

@daviddias
Copy link
Member

@dryajov this PR is not the one introducing that dependency, what do you mean by blocked?

@daviddias daviddias merged commit d7732c3 into master Oct 20, 2017
@ghost ghost removed the status/in-progress In progress label Oct 20, 2017
@daviddias daviddias deleted the feat/cli-progress-bar branch October 20, 2017 19:00
@dryajov
Copy link
Member Author

dryajov commented Oct 20, 2017

blocking in the sense that we probably shouldn't release js-ipfs without this fixed. But your right, we should not hold this PR because of it.

@attritionorg
Copy link

Without giving away too many details, can someone cliff notes the vulnerability / severity?

@dryajov
Copy link
Member Author

dryajov commented Oct 24, 2017

@attritionorg here you go - https://nodesecurity.io/orgs/ipfs/projects/f983c9d5-424b-436a-ae6f-733dddb9ad08/1042. Keep in mind, this is a vulnerability in the static-eval that is used by many of our dependencies.

@attritionorg
Copy link

@dryajov Excellent, thank you!

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

progress bar disappears too soon
3 participants