Updating CI files #1103

victorb · 2017-11-22T12:08:35Z

This commit updates all CI scripts to the latest version

daviddias · 2017-11-23T11:30:59Z

rebased master onto this branch so that CI is happy

daviddias · 2017-11-23T11:54:20Z

circle.yml

    - sudo apt-get update
-    - sudo apt-get install -f || true
-    - sudo dpkg -i libnss3*.deb


@victorbjelkholm this is breaking chrome on CI

@diasdavid yeah, because js-ipfs is still using old Ubuntu version (on CircleCI). Once this PR is ready to be merged (all CIs except CircleCI passing), we'll upgrade the version and confirm all CIs again and then merge this.

I'm not sure if you need me to do something or if it is all part of your plan. Let me know if you need my help :)

@victorbjelkholm shall I go ahead and merge this PR?

codecov · 2017-11-23T15:32:50Z

Codecov Report

❗ No coverage uploaded for pull request base (master@e7f0432). Click here to learn what that means.
The diff coverage is n/a.

@@            Coverage Diff            @@
##             master    #1103   +/-   ##
=========================================
  Coverage          ?   83.68%           
=========================================
  Files             ?      122           
  Lines             ?     2752           
  Branches          ?        0           
=========================================
  Hits              ?     2303           
  Misses            ?      449           
  Partials          ?        0

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update e7f0432...2b3b21c. Read the comment docs.

daviddias · 2017-12-02T15:20:58Z

@victorbjelkholm any update here?

daviddias · 2017-12-10T09:27:47Z

@victorbjelkholm you will have to rebase master onto this branch.

daviddias · 2017-12-10T09:33:11Z

Just rebaed it for you :)

victorb · 2017-12-18T09:28:09Z

Just missing one test case on windows to be ready to merge.

Failing case:

  15) cli
       init
         basic:

      AssertionError: expected '' to equal 'Hello and Welcome to IPFS!\n\n██╗██████╗ ███████╗███████╗\n██║██╔══██╗██╔════╝██╔════╝\n██║██████╔╝█████╗  ███████╗\n██║██╔═══╝ ██╔══╝  ╚════██║\n██║██║     ██║     ███████║\n╚═╝╚═╝     ╚═╝     ╚══════╝\n\nIf you\'re seeing this, you have successfully installed\nIPFS and are now interfacing with the ipfs merkledag!\n\n -------------------------------------------------------\n| Warning:                                              |\n|   This is alpha software. Use at your own discretion! |\n|   Much is missing or lacking polish. There are bugs.  |\n|   Not yet secure. Read the security notes for more.   |\n -------------------------------------------------------\n\nCheck out some of the other files in this directory:\n\n  ./about\n  ./help\n  ./quick-start     <-- usage examples\n  ./readme          <-- this file\n  ./security-notes\n'
      + expected - actual

      +Hello and Welcome to IPFS!
      +
      +██╗██████╗ ███████╗███████╗
      +██║██╔══██╗██╔════╝██╔════╝
      +██║██████╔╝█████╗  ███████╗
      +██║██╔═══╝ ██╔══╝  ╚════██║
      +██║██║     ██║     ███████║
      +╚═╝╚═╝     ╚═╝     ╚══════╝
      +
      +If you're seeing this, you have successfully installed
      +IPFS and are now interfacing with the ipfs merkledag!
      +
      + -------------------------------------------------------
      +| Warning:                                              |
      +|   This is alpha software. Use at your own discretion! |
      +|   Much is missing or lacking polish. There are bugs.  |
      +|   Not yet secure. Read the security notes for more.   |
      + -------------------------------------------------------
      +
      +Check out some of the other files in this directory:
      +
      +  ./about
      +  ./help
      +  ./quick-start     <-- usage examples
      +  ./readme          <-- this file
      +  ./security-notes
      
      at ipfs.then.then (test\cli\init.js:47:37)
      at <anonymous>
      at process._tickDomainCallback (internal/process/next_tick.js:228:7)

victorb · 2017-12-18T10:44:27Z

Hm, seems I got confused by the large stacktrace in the test output, and there is lots more of windows tests failing.

Could we get some help from @richardschneider or @hacdias maybe?

richardschneider · 2017-12-19T04:08:17Z

@victorbjelkholm Starting to look at the issues!

daviddias · 2017-12-28T08:16:52Z

@richardschneider did you had time to check this?

richardschneider · 2017-12-28T08:28:36Z

@diasdavid I think #1159 resolved the issues. Please tell me if any more issues exist.

daviddias · 2017-12-28T08:46:19Z

All right, just rebased master onto this one. Let's see :)

daviddias · 2017-12-28T09:03:01Z

Weird, Jenkins disappeared from the list (the one not showing is just Node Security)

@victorbjelkholm ?

daviddias · 2018-01-23T07:13:08Z

@victorbjelkholm what's up with Jenkins?

victorb · 2018-01-23T10:45:33Z

@diasdavid from the last rows in the output, it's a merge conflict. Github also confirms this is a merge conflict.

I'll figure out the resolution of this today.

daviddias · 2018-02-27T14:00:20Z

@victorbjelkholm Jenkins is showing some new failtures after the .gitignore but that are unrelated. Have you seen these?

daviddias · 2018-02-27T14:04:36Z

Ah, I think the real problem from here -- #1103 (comment) -- is that now the tests are running over the repo that should be just used to be c&p to a tmp folder but that with #1234 it stopped being, since the ncp + rimraf was removed.

@dryajov wanna fix that?

daviddias · 2018-02-27T18:24:48Z

Just Windows issues left -- https://ci.ipfs.team/blue/organizations/jenkins/IPFS%2Fjs-ipfs/detail/PR-1103/73/tests -- and timeouts on Travis -- https://travis-ci.org/ipfs/js-ipfs/builds/346889245#L6612-L6626.

dryajov · 2018-02-27T18:29:29Z

@victorbjelkholm I think they are mostly related to gratious shutdown.

daviddias · 2018-02-27T18:30:40Z

@dryajov didn't everyone agree that any ipfs shutdown related issue (which will be fixed post release) should be/is skipped?

dryajov · 2018-02-27T18:33:16Z

@diasdavid it makes total sense, but I didn't hear we were actually doing this.skip() on them.

dryajov · 2018-02-27T19:02:08Z

BTW, I think we should just merge as we know what the issues are and are already handling them elsewhere.

Here is my 👍

dryajov · 2018-02-27T20:15:19Z

Ah, #1103 (comment), I wasn't in that standup. Gonna skip them.

daviddias · 2018-02-27T22:31:36Z

@dryajov we are not doing a release with red CI (except for Appveyor, thanks go-ipfs 0.4.13..). Travis is failing one of the highlights of this release is faster CI through Jenkins.

dryajov · 2018-02-27T22:36:03Z

@diasdavid I traced it back to the relevant convo - #1103 (comment). I'm skipping those tests that will fail due to lack of gracious stop.

dryajov · 2018-02-27T23:20:21Z

Last run on jenkins was successful

Also, we seem to have green CI all around (except for travis PR which is still going)

dryajov · 2018-02-27T23:29:24Z

All is green.

daviddias · 2018-02-28T00:27:51Z

Rerun everything again, failed:

daviddias · 2018-02-28T01:32:24Z

Seems that it is passing again :) might have been a hiccup.

victorb · 2018-02-28T09:54:44Z

Flaky tests be flaky! But yay, Jenkins 🎉

This is a round up of the remaining async/await PRs along with some cleanup and docs fixes. resolves ipfs#1103 resolves ipfs-inactive/js-ipfs-http-client#1122 resolves ipfs-inactive/js-ipfs-http-client#1158 (hopefully!) closes ipfs-inactive/js-ipfs-http-client#1164 closes ipfs-inactive/js-ipfs-http-client#1165 closes ipfs-inactive/js-ipfs-http-client#1166 closes ipfs-inactive/js-ipfs-http-client#1169 closes ipfs-inactive/js-ipfs-http-client#1170 closes ipfs-inactive/js-ipfs-http-client#1172 BREAKING CHANGE: The `log.tail` method now returns an async iterator that yields log messages. Use it like: ```js for await (const message of ipfs.log.tail()) { console.log(message) } ``` BREAKING CHANGE: The response to a call to `log.level` now returns an object that has camel cased keys. i.e. `Message` and `Error` properties have changed to `message` and `error`. BREAKING CHANGE: Dropped support for go-ipfs <= 0.4.4 in `swarm.peers` response. BREAKING CHANGE: The signature for `ipfs.mount` has changed from `ipfs.mount([ipfsPath], [ipnsPath])` to `ipfs.mount([options])`. Where `options` is an optional object that may contain two boolean properties `ipfsPath` and `ipnsPath`. The response object has also changed to be camel case. See https://docs.ipfs.io/reference/api/http/#api-v0-mount. BREAKING CHANGE: Default ping `count` of 1 in client has been removed. The default ping count is now whatever the IPFS node defaults it to (currently 10). If you specifically need 1 ping message then please pass `count: 1` in options for `ipfs.ping()`. BREAKING CHANGE: Multi parameter constructor options are no longer supported. To create a new IPFS HTTP client, pass a single parameter to the constructor. The parameter can be one of: * String, formatted as one of: * Multiaddr e.g. /ip4/127.0.0.1/tcp/5001 * URL e.g. http://127.0.0.1:5001 * [Multiaddr](https://www.npmjs.com/package/multiaddr) instance * Object, in format of either: * Address and path e.g. `{ apiAddr: '/ip4/127.0.0.1/tcp/5001': apiPath: '/api/v0' }` (Note: `apiAddr` can also be a string in URL form or a Multiaddr instance) * Node.js style address e.g. `{ host: '127.0.0.1', port: 5001, protocol: 'http' }`

ghost assigned victorb Nov 22, 2017

ghost added the status/in-progress In progress label Nov 22, 2017

daviddias force-pushed the automatic-ci-script-update branch from 074b166 to 394200a Compare November 23, 2017 11:30

daviddias reviewed Nov 23, 2017

View reviewed changes

victorb force-pushed the automatic-ci-script-update branch from 394200a to 17f4d1d Compare November 23, 2017 15:32

daviddias force-pushed the automatic-ci-script-update branch from 17f4d1d to e21c8f1 Compare December 2, 2017 15:21

ghost assigned daviddias Dec 2, 2017

daviddias force-pushed the automatic-ci-script-update branch from e21c8f1 to d6d1e4e Compare December 10, 2017 09:32

daviddias removed their assignment Dec 11, 2017

victorb force-pushed the automatic-ci-script-update branch 2 times, most recently from 9aec32d to a7de496 Compare December 18, 2017 09:04

richardschneider mentioned this pull request Dec 19, 2017

cli files on Windows #1159

Merged

victorb force-pushed the automatic-ci-script-update branch from a7de496 to e30a2c9 Compare December 22, 2017 09:57

daviddias force-pushed the automatic-ci-script-update branch from e30a2c9 to 069c2e4 Compare December 28, 2017 08:45

ghost assigned daviddias Dec 28, 2017

victorb force-pushed the automatic-ci-script-update branch from 069c2e4 to 5d56dfc Compare December 28, 2017 11:31

daviddias dismissed their stale review via 16e393d February 27, 2018 13:32

chore: update gitignore

d16727d

daviddias force-pushed the automatic-ci-script-update branch from 16e393d to d16727d Compare February 27, 2018 14:03

fix: copy repo for tests

540e5f6

ghost assigned dryajov Feb 27, 2018

fix: skip failing tests on windows

72fdde4

dryajov added 3 commits February 27, 2018 14:47

fix: Addresses.Swarm is empty since we cant stop daemon on windows

5925ecc

fix: move skipOnWindows to top

fe9e06e

lint

2b3b21c

daviddias approved these changes Feb 28, 2018

View reviewed changes

daviddias merged commit bc66e9f into master Feb 28, 2018

ghost removed the status/in-progress In progress label Feb 28, 2018

daviddias deleted the automatic-ci-script-update branch February 28, 2018 01:33

victorb mentioned this pull request Aug 13, 2018

Replace Teamcity/TravisCI/CircleCI with Jenkins ipfs-inactive/dev-team-enablement#78

Closed

5 tasks

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Updating CI files #1103

Updating CI files #1103

victorb commented Nov 22, 2017

daviddias commented Nov 23, 2017

daviddias Nov 23, 2017

victorb Nov 23, 2017 •

edited

Loading

daviddias Nov 24, 2017

daviddias Dec 7, 2017

codecov bot commented Nov 23, 2017 •

edited

Loading

daviddias commented Dec 2, 2017

daviddias commented Dec 10, 2017

daviddias commented Dec 10, 2017

victorb commented Dec 18, 2017

victorb commented Dec 18, 2017

richardschneider commented Dec 19, 2017

daviddias commented Dec 28, 2017

richardschneider commented Dec 28, 2017

daviddias commented Dec 28, 2017

daviddias commented Dec 28, 2017 •

edited

Loading

daviddias commented Jan 23, 2018

victorb commented Jan 23, 2018

daviddias commented Feb 27, 2018

daviddias commented Feb 27, 2018

daviddias commented Feb 27, 2018 •

edited

Loading

dryajov commented Feb 27, 2018

daviddias commented Feb 27, 2018

dryajov commented Feb 27, 2018

dryajov commented Feb 27, 2018

dryajov commented Feb 27, 2018

daviddias commented Feb 27, 2018

dryajov commented Feb 27, 2018

dryajov commented Feb 27, 2018

dryajov commented Feb 27, 2018

daviddias commented Feb 28, 2018

daviddias commented Feb 28, 2018

victorb commented Feb 28, 2018

Updating CI files #1103

Updating CI files #1103

Conversation

victorb commented Nov 22, 2017

daviddias commented Nov 23, 2017

daviddias Nov 23, 2017

Choose a reason for hiding this comment

victorb Nov 23, 2017 • edited Loading

Choose a reason for hiding this comment

daviddias Nov 24, 2017

Choose a reason for hiding this comment

daviddias Dec 7, 2017

Choose a reason for hiding this comment

codecov bot commented Nov 23, 2017 • edited Loading

Codecov Report

daviddias commented Dec 2, 2017

daviddias commented Dec 10, 2017

daviddias commented Dec 10, 2017

victorb commented Dec 18, 2017

victorb commented Dec 18, 2017

richardschneider commented Dec 19, 2017

daviddias commented Dec 28, 2017

richardschneider commented Dec 28, 2017

daviddias commented Dec 28, 2017

daviddias commented Dec 28, 2017 • edited Loading

daviddias commented Jan 23, 2018

victorb commented Jan 23, 2018

daviddias commented Feb 27, 2018

daviddias commented Feb 27, 2018

daviddias commented Feb 27, 2018 • edited Loading

dryajov commented Feb 27, 2018

daviddias commented Feb 27, 2018

dryajov commented Feb 27, 2018

dryajov commented Feb 27, 2018

dryajov commented Feb 27, 2018

daviddias commented Feb 27, 2018

dryajov commented Feb 27, 2018

dryajov commented Feb 27, 2018

dryajov commented Feb 27, 2018

daviddias commented Feb 28, 2018

daviddias commented Feb 28, 2018

victorb commented Feb 28, 2018

victorb Nov 23, 2017 •

edited

Loading

codecov bot commented Nov 23, 2017 •

edited

Loading

daviddias commented Dec 28, 2017 •

edited

Loading

daviddias commented Feb 27, 2018 •

edited

Loading