Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: update *-star multiaddrs to explicity say that they need tcp and a port #1117

Merged
merged 9 commits into from
Dec 1, 2017

Conversation

@ghost ghost assigned daviddias Nov 28, 2017
@ghost ghost added the status/in-progress In progress label Nov 28, 2017
@daviddias daviddias mentioned this pull request Nov 28, 2017
24 tasks
@codecov
Copy link

codecov bot commented Nov 30, 2017

Codecov Report

Merging #1117 into master will increase coverage by <.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #1117      +/-   ##
==========================================
+ Coverage   83.48%   83.49%   +<.01%     
==========================================
  Files         121      121              
  Lines        2725     2726       +1     
==========================================
+ Hits         2275     2276       +1     
  Misses        450      450
Impacted Files Coverage Δ
src/core/runtime/libp2p-nodejs.js 92.3% <100%> (ø) ⬆️
src/core/index.js 98.63% <0%> (+0.01%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 58ded8d...072700c. Read the comment docs.

@daviddias
Copy link
Member Author

@pgte something weird is happening with the latest p2p-websocket-star, the example exchange files never starts the node (it was before).

@pgte
Copy link
Contributor

pgte commented Nov 30, 2017

@diasdavid checking it out.

@pgte
Copy link
Contributor

pgte commented Nov 30, 2017

@diasdavid it's yielding this error for me:

ipfs_-_transfer_files

@pgte
Copy link
Contributor

pgte commented Nov 30, 2017

Will push a fix for this.

@ghost ghost assigned pgte Nov 30, 2017
@pgte
Copy link
Contributor

pgte commented Nov 30, 2017

@diasdavid pushed temporary fix for the latest problem, allowing websocket-star join with disabled challenge. Without that, for now, websocket-star doesn't seam to work..

@daviddias
Copy link
Member Author

We want the crypto challenged enabled. seems that the version deployed is the wrong one. //cc @victorbjelkholm

@ghost ghost assigned hacdias Dec 1, 2017
@hacdias
Copy link
Member

hacdias commented Dec 1, 2017

This also fixes the problem we were having when getting a file. @diasdavid and I were looking into that and David found out that the Blob API has changed. 😄 It works now!

@daviddias daviddias merged commit 9eda8a8 into master Dec 1, 2017
@daviddias daviddias deleted the fix-multiaddrs branch December 1, 2017 10:21
@ghost ghost removed the status/in-progress In progress label Dec 1, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants