Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

Add dependencies from package.json to Packages table in README.md #1161

Merged
merged 3 commits into from
Dec 22, 2017

Conversation

jonahweissman
Copy link
Contributor

I checked the README.md for each repo to find the missing badges. A lot were missing Circle CI and coverage badges. I couldn't find the AppVeyor badges for any of them, but I probably just don't know where to look. If someone tells me how, I'd be happy to add the missing badges.

Here are the packages I added. I may have missed some.

  • libp2p-circuit
  • libp2p-floodsub
  • libp2p-kad-dht
  • libp2p-mdns
  • libp2p-multiplex
  • libp2p-railing
  • libp2p-secio
  • libp2p-tcp
  • libp2p-webrtc-star
  • libp2p-websocket-star
  • libp2p-websockets
  • ipfs-bitswap
  • is-ipfs

closes #1050

@daviddias
Copy link
Member

This is rad @jonahweissman, thank so much for completing the table! The appveyor badges are indeed more tricky, you should be able to get them using https://ci.appveyor.com/project/wubalubadubdub/<name of the repo> and then using one of the existing badges as template, example: https://raw.githubusercontent.com/ipfs/js-ipfsd-ctl/master/README.md.

Do you feel like still doing that part?

@jonahweissman
Copy link
Contributor Author

@diasdavid Yeah, no problem! I'll get it done soon

@jonahweissman
Copy link
Contributor Author

@diasdavid I have added the AppVeyor badges!

Unfortunately, I couldn't figure out how to find the link the AppVeyor project, so I just made them images. I'm guessing someone with write access needs to do that because AppVeyor was giving me

Project not found or access denied.

when I tried to go to the project pages. (Example of page that I can't view: https://ci.appveyor.com/project/wubalubadubdub/ipfs-repo)

Also, some of the coverage badges show up as "unknown" and the project pages say

THIS REPO HAS NOT RECEIVED ANY JOBS YET.

I tried to "add repo" on Coveralls, but, again, I think someone with write access needs to that.

@daviddias
Copy link
Member

This is great @jonahweissman 🌟 Now we have a way to tell which repos are missing and what.

@daviddias daviddias merged commit b22f9a4 into ipfs:master Dec 22, 2017
@jonahweissman jonahweissman deleted the iss1050-package-table branch December 22, 2017 15:06
MicrowaveDev pushed a commit to galtproject/js-ipfs that referenced this pull request May 22, 2020
This switches out `tar-stream` for [`it-tar`](https://www.npmjs.com/package/it-tar), which is a fork that uses pure async iterables. This removes `readable-stream` from this branch of the tree (which will allow us to drop it entirely in the future) and allows us to drop the `event-iterator` dependency.
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Complete Packages Table
2 participants