Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: ipfs version flags + ipfs repo version (#1181) #1188

Merged
merged 2 commits into from
Feb 18, 2018
Merged

Conversation

daviddias
Copy link
Member

@daviddias daviddias commented Jan 25, 2018

@JonKrone I've found the issue, see: https://github.com/ipfs/js-ipfs/pull/1181/files#r163727102

Wanna take a stab at finishing the PR?

You can see where the error comes from if you run make test --verbose

» ./t0010-basic-commands.sh --verbose
expecting success:
        echo "It works!" > test.txt

ok 1 - current dir is writable

expecting success:
        ipfs version > version.txt

/Users/imp/code/js-ipfs/src/core/components/version.js:16
        throw err
        ^

Error: ENOENT: no such file or directory, open '/Users/imp/code/js-ipfs/test/sharness/trash directory.t0010-basic-commands.sh/.jsipfs/version'

@ghost ghost assigned daviddias Jan 25, 2018
@ghost ghost added the status/in-progress In progress label Jan 25, 2018
@daviddias daviddias removed their assignment Jan 25, 2018
@daviddias
Copy link
Member Author

daviddias commented Jan 30, 2018

@JonKrone are you looking into the failing test? Is there anything I can help with?

@JonKrone
Copy link
Contributor

JonKrone commented Jan 30, 2018

Hey @diasdavid Thanks for checking in, I just opened up #1199 with this code + the fix.

Might take another commit or two to fix tests I wasn't able to run locally.

@ghost ghost assigned daviddias Feb 1, 2018
@daviddias
Copy link
Member Author

Done in #1199

@daviddias daviddias closed this Feb 15, 2018
@daviddias daviddias deleted the pr1181 branch February 15, 2018 08:48
@ghost ghost removed the status/in-progress In progress label Feb 15, 2018
@JonKrone
Copy link
Contributor

@diasdavid #1199 merged changes into a pr1181 branch but pr1181 was not merged into master, I believe

@daviddias daviddias restored the pr1181 branch February 16, 2018 17:17
@daviddias daviddias reopened this Feb 16, 2018
@ghost ghost added the status/in-progress In progress label Feb 16, 2018
@daviddias
Copy link
Member Author

My bad, saw that incorrectly. @JonKrone still looking to finish this one?

@JonKrone
Copy link
Contributor

No worries. Is there something else that this needs? I believe it's complete but I may have missed some connections between an impl here and things like ipfs-api.

I think failing travis CI is unrelated.

@daviddias
Copy link
Member Author

@JonKrone needs rebase for clean merge and CI to pass.

I've added you to the JavaScript team on the IPFS org so that you can collab with us directly on repo branches. Welcome!! Use your new perms wisely 🕸️

Thank you for all the help you have been providing :)

@daviddias
Copy link
Member Author

@JonKrone just rebased for you :) Now waiting on CI

@daviddias
Copy link
Member Author

Circle is happy

image

@daviddias daviddias merged commit 494da7f into master Feb 18, 2018
@daviddias daviddias deleted the pr1181 branch February 18, 2018 09:15
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants