-
Notifications
You must be signed in to change notification settings - Fork 1.2k
feat: ipfs version
flags + ipfs repo version
(#1181)
#1188
Conversation
@JonKrone are you looking into the failing test? Is there anything I can help with? |
Hey @diasdavid Thanks for checking in, I just opened up #1199 with this code + the fix. Might take another commit or two to fix tests I wasn't able to run locally. |
Done in #1199 |
@diasdavid #1199 merged changes into a pr1181 branch but pr1181 was not merged into master, I believe |
My bad, saw that incorrectly. @JonKrone still looking to finish this one? |
No worries. Is there something else that this needs? I believe it's complete but I may have missed some connections between an impl here and things like ipfs-api. I think failing travis CI is unrelated. |
@JonKrone needs rebase for clean merge and CI to pass. I've added you to the JavaScript team on the IPFS org so that you can collab with us directly on repo branches. Welcome!! Use your new perms wisely 🕸️ Thank you for all the help you have been providing :) |
@JonKrone just rebased for you :) Now waiting on CI |
@JonKrone I've found the issue, see: https://github.com/ipfs/js-ipfs/pull/1181/files#r163727102
Wanna take a stab at finishing the PR?
You can see where the error comes from if you run
make test --verbose