This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
fix: remove unused var #1273
Merged
fix: remove unused var #1273
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
added
the
|
Thanks @fsdiogo! @victorbjelkholm Looking at #1230, and then looking at a couple other PRs, it seems like linting isn't being run during CI, at least on Travis. Is this a regression, intentional, or am I missing something? |
|
It should be run in Circle. Can you add it back it too? Thanks @fsdiogo :) |
|
update from IRC: @victorbjelkholm is working on adding it to jenkins 👍 |
|
I've added linting to the jenkins job now and retried the jenkins jobs for this pr. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removed an unused var that was producing a linter error.