Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

fix: adds missing breaking changes for 0.29 to changelog #1370

Merged
merged 1 commit into from
May 30, 2018
Merged
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
14 changes: 10 additions & 4 deletions CHANGELOG.md
Original file line number Diff line number Diff line change
Expand Up @@ -53,10 +53,16 @@

### BREAKING CHANGES

* pubsub.unsubscribe is now async and argument order for pubsub.subscribe has changed

License: MIT
Signed-off-by: Alan Shaw <alan@tableflip.io>
1. Argument order for `pubsub.subscribe` has changed:
* Old: `pubsub.subscribe(topic, [options], handler, [callback]): Promise`
* New: `pubsub.subscribe(topic, handler, [options], [callback]): Promise`
2. The `pubsub.unsubscribe` method has become async meaning that it now takes a callback or returns a promise:
* Old: `pubsub.unsubscribe(topic, handler): undefined`
* New: `pubsub.unsubscribe(topic, handler, [callback]): Promise`
3. Property names on response objects for `ping` are now lowered:
* Old: `{ Success, Time, Text }`
* New: `{ success, time, text }`
4. In the CLI, `jsipfs object data` no longer returns a newline after the end of the returned data



Expand Down