This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
refactor: use types test from interface-ipfs-core #1696
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
vmx
force-pushed
the
remove-types-test
branch
from
09b8ca2 to
4b65b3e
Compare
vmx
changed the title
The test for types also exists in interface-ipfs-core, which is the central test repository for both js-ipfs and js-http-api tests. Pulling in the test once from there is enough.
vmx
force-pushed
the
remove-types-test
branch
from
4b65b3e to
108d3a9
Compare
|
CI is green, only circleci failed. |
alanshaw
approved these changes
Nov 9, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The test for types also exists in interface-ipfs-core, which is the
central test repository for both js-ipfs and js-http-api tests.
Pulling in the test once from there is enough.