Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

feat: rev mfs and unixfs to support hamt in mfs #1734

Merged
merged 3 commits into from
Dec 5, 2018
Merged

feat: rev mfs and unixfs to support hamt in mfs #1734

merged 3 commits into from
Dec 5, 2018

Conversation

achingbrain
Copy link
Member

In order to support really large directories

@ghost ghost assigned achingbrain Nov 28, 2018
@ghost ghost added the status/in-progress In progress label Nov 28, 2018
daviddias
daviddias approved these changes Nov 28, 2018
View reviewed changes
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!! :D

@alanshaw
Copy link
Member

Would you mind rebasing for green CI please?

@achingbrain achingbrain changed the title feat: rev mfs and unixfs to support hamt in mfs WIP feat: rev mfs and unixfs to support hamt in mfs Nov 29, 2018
@alanshaw
Copy link
Member

Is this still WIP @achingbrain?

@achingbrain
Copy link
Member Author

Yes, just adding some more tests to verify that adding nodes to sharded directories results in the same hashes as if they were added in one go by the importer.

@achingbrain achingbrain force-pushed the mfs-sharding-support branch 2 times, most recently from 36337d2 to 044184d Compare December 3, 2018 13:12
@alanshaw alanshaw mentioned this pull request Dec 3, 2018
Closed
49 tasks
@alanshaw alanshaw changed the title WIP feat: rev mfs and unixfs to support hamt in mfs [WIP] feat: rev mfs and unixfs to support hamt in mfs Dec 4, 2018
@alanshaw
Copy link
Member

alanshaw commented Dec 4, 2018

@achingbrain FYI node tests are currently all fails 😞

@achingbrain
Copy link
Member Author

@alanshaw this'll need ipfs-inactive/interface-js-ipfs-core#401 merging first.

@achingbrain
Copy link
Member Author

Also ipfs-inactive/js-ipfs-http-client#903

@achingbrain achingbrain changed the title [WIP] feat: rev mfs and unixfs to support hamt in mfs feat: rev mfs and unixfs to support hamt in mfs Dec 5, 2018
@achingbrain achingbrain mentioned this pull request Dec 5, 2018
Merged
@alanshaw
Copy link
Member

alanshaw commented Dec 5, 2018

Both merged and released 🚢

@achingbrain
Copy link
Member Author

Hmm, one test failure just now, pubsub related:

1) interface-ipfs-core tests,.name.pubsub.cancel

       should cancel a subscription correctly returning true:

     Error: Uncaught AssertionError: expected [ Array(1) ] to include '/ipns/QmcSaAyZTYcCq8M47jFsAabreuFzUNAPbVVjcYJZUWfczz' (webpack://ipfs/node_modules/chai/lib/chai/assertion.js:141 <- node_modules/aegir/src/config/karma-entry.js:36516)

@alanshaw
Copy link
Member

alanshaw commented Dec 5, 2018

Merging - browser test failure is unrelated - .name.pubsub.cancel - ping @vasco-santos

@alanshaw alanshaw merged commit 83b8e9b into master Dec 5, 2018
@alanshaw alanshaw deleted the mfs-sharding-support branch December 5, 2018 17:06
@ghost ghost removed the status/in-progress In progress label Dec 5, 2018
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@daviddias daviddias daviddias approved these changes

@alanshaw alanshaw alanshaw approved these changes

Assignees

@achingbrain achingbrain

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@achingbrain @alanshaw @daviddias