This repository has been archived by the owner on Feb 12, 2024. It is now read-only.
feat: add from url/stream #1773
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ghost
assigned 
alanshaw
force-pushed
the
feat/add-from-url
branch
2 times, most recently
from
237e6f8
to
8d9b167
Compare
alanshaw
force-pushed
the
feat/add-from-url
branch
from
8d9b167
to
3bee947
Compare
added 3 commits
December 12, 2018 09:17
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
License: MIT Signed-off-by: Alan Shaw <alan.shaw@protocol.ai>
alanshaw
force-pushed
the
feat/add-from-url
branch
from
830fef2
to
e44bab7
Compare
alanshaw
requested review from
daviddias,
hugomrdias,
vasco-santos and
achingbrain
achingbrain
reviewed
Dec 12, 2018
| const fetch = require('../../runtime/fetch-nodejs') | ||
|
|
||
| module.exports = (self) => { | ||
| return async (url, options, callback) => { |
There was a problem hiding this comment.
async methods that take callbacks. The async/await refactor cannot come soon enough.
achingbrain
approved these changes
Dec 12, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
depends on #1772