Skip to content
This repository has been archived by the owner on Feb 12, 2024. It is now read-only.

[WIP] feat: add stardust behind flag "EXPERIMENTAL.stardust" #1812

Closed
wants to merge 2 commits into from

Conversation

mkg20001
Copy link
Contributor

This adds support for the stardust protocol behind the flag
EXPERIMENTAL.stardust

This pr is part of the endeavour to replace ws-star with stardust for
the time being until a better solution is found.

See the discussion at
libp2p/js-libp2p-websocket-star#70 (comment)
for more information

Ref #1767

This adds support for the stardust protocol behind the flag 
EXPERIMENTAL.stardust

This pr is part of the endeavour to replace ws-star with stardust for 
the time being until a better solution is found.

See the discussion at 
libp2p/js-libp2p-websocket-star#70 (comment) 
for more information
@alanshaw
Copy link
Member

@mkg20001 does this have dependencies on other PRs that I need to consider?

@mkg20001
Copy link
Contributor Author

Yes. libp2p/js-libp2p-crypto#125 (a pr where I need some help with adding the .encrypt() method with webcrypto) multiformats/js-multiaddr#78 (needs merge&release) multiformats/js-mafmt#35 (needs merge&release, depends on previous pr)

@alanshaw alanshaw changed the title feat: add stardust behind flag "EXPERIMENTAL.stardust" [WIP] feat: add stardust behind flag "EXPERIMENTAL.stardust" Jan 22, 2019
Copy link
Member

@daviddias daviddias left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not in favor to merge this PR. Extra transports should be passed in through config.libp2p on the constructor, not through extra hard coded flags.

@mkg20001 wanna write instead a tutorial/example on how to use different transports for Js-ipfs and go through the path that a dev would take, making sure it is as nicer as it can be?

@alanshaw
Copy link
Member

Unless I'm missing something, we don't need an experimental flag for this since you can enable it through constructor config already. I think we should instead add a stardust example and mention it in the README as an alternative transport that people can use.

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants