cli: add --human flag to repo stat & stats repo #2102
Conversation
|
Screenshot of the output |
There was a problem hiding this comment.
Please would you add a unit test for this handler to assert that it is converting the values to human readable form when the human flag is passed?
Note you can make this easier to test by changing the handler to return the value you want to print (it'll be printed automatically) instead of using the print function.
src/cli/utils.js
Outdated
| } while (Math.abs(bytes) >= thresh && unit < units.length - 1) | ||
| return bytes.toFixed(1) + ' ' + units[unit] | ||
| } | ||
| } |
There was a problem hiding this comment.
Can we please use a tested module on npm for this? ipfs-http-response already uses filesize - can we use the same module?
- Added a `humanize` object to /src/cli/utils with `Bytes` method that takes bytes and returns Human readable size. - Used `humanize.Bytes()` method in /commands/stats/repo and /commands/repo/stat if `--human` flag is passed. License: MIT Signed-off-by: Chirag Shinde <shinde.chirag2204@gmail.com>
- Use filesize to return human readable sizes. - handler now returns stats instead of printing them. License: MIT Signed-off-by: Chirag Shinde <shinde.chirag2204@gmail.com>
chirag-shinde
force-pushed
the
humanize-repo-stat
branch
from
a4faca8
to
69523e8
Compare
|
I'd like some help with writing the unit test for handler please. |
|
Hi! js-ipfs master just got a whole new set of automated tests with #2528, #2440 and also running some of the test suites from our early testers (hi5 to @achingbrain for setting it all up!). Would you mind rebasing the master branch on this PR to ensure it runs all the latest tests? Thank you! |
humanizeobject to /src/cli/utils withBytesmethodthat takes bytes and returns Human readable size.
humanize.Bytes()method in /commands/stats/repo and/commands/repo/stat if
--humanflag is passed.solves #1996
License: MIT
Signed-off-by: Chirag Shinde shinde.chirag2204@gmail.com